From owner-freebsd-commit  Mon May 15 00:52:22 1995
Return-Path: commit-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id AAA21025
          for commit-outgoing; Mon, 15 May 1995 00:52:22 -0700
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id AAA21012
          for cvs-usrbin-outgoing; Mon, 15 May 1995 00:52:20 -0700
Received: from Root.COM (implode.Root.COM [198.145.90.1])
          by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id AAA21004
          ; Mon, 15 May 1995 00:52:12 -0700
Received: from corbin.Root.COM (corbin.Root.COM [198.145.90.18]) by Root.COM (8.6.8/8.6.5) with ESMTP id AAA05153; Mon, 15 May 1995 00:55:17 -0700
Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.11/8.6.5) with SMTP id AAA00193; Mon, 15 May 1995 00:52:13 -0700
Message-Id: <199505150752.AAA00193@corbin.Root.COM>
To: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>
cc: vode@freud.hut.fi (Kai Vorma), nate@trout.sri.mt.net,
        ache@freefall.cdrom.com, CVS-commiters@freefall.cdrom.com,
        cvs-usrbin@freefall.cdrom.com
Subject: Re: cvs commit: src/usr.bin/rpcgen rpc_parse.c 
In-reply-to: Your message of "Mon, 15 May 95 00:31:18 PDT."
             <199505150731.AAA05385@gndrsh.aac.dev.com> 
From: David Greenman <davidg@Root.COM>
Reply-To: davidg@Root.COM
Date: Mon, 15 May 1995 00:52:11 -0700
Sender: commit-owner@FreeBSD.org
Precedence: bulk

>> On Sun, 14 May 1995, Nate Williams wrote:
>> 
>> > Andrey A. Chernov writes:
>> > > ache        95/05/14 17:03:33
>> > > 
>> > >   Modified:    usr.bin/rpcgen  rpc_parse.c
>> > >   Log:
>> > >   End of listcan be not marked, fix it
>> > >   Submitted by: Kai Vorma <vode@snakemail.hut.fi>
>> > 
>> > I looked at this fix, and I'm not sure that the proposed 'fix' was
>> > necessary.  Did you look at the fix at determine if it was indeed needed?
>> 
>> Without this fix the last plist->next link is uninitialized. rpcgen
>> still works, because the way BSD malloc works (it cannot reuse freed
>> memory so it asks more from the system and that memory is zeroed ->
>> next-link happens to be NULL). 
>> 
>> I have replaced the system malloc with a better one and rpcgen
>> dumps core without this patch.
>
>Then this is not a critical bug fix, becuase as ship freebsd does not
>have the bug!
>
>Are you *absolutely* sure your change has no side effects that would
>cause something else to break?  If so I can live with this change,
>if not, I am probably going to step a cvs admin -o maj.min on rpc_parse.c
>and obsolete this last change until after the release is done.

   I've looked at the change closely and it is correct. In all cases, the
"proc_list" is expected to be terminated by a NULL 'next' pointer. The NULL
must be assigned here because this is where the list is allocated/constructed,
and there is no other place where this can occur.

-DG