From nobody Wed Feb 15 17:07:08 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PH4JB4MXRz3qZKV for ; Wed, 15 Feb 2023 17:07:22 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PH4J94Z4Qz3v9L for ; Wed, 15 Feb 2023 17:07:21 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20210112.gappssmtp.com header.s=20210112 header.b=hu8YVmDN; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2a00:1450:4864:20::532) smtp.mailfrom=wlosh@bsdimp.com; dmarc=none Received: by mail-ed1-x532.google.com with SMTP id n20so8427863edy.0 for ; Wed, 15 Feb 2023 09:07:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=YQX8sml47RFjV0+UFD1g3dvbgVChVLgA+ZXVuKnEBDA=; b=hu8YVmDNq30Zab3c9XyXpOC5/4cfhG/+sBCvhLnbUnKt3tMua+NuAAqi/rAtvWJ9c9 eXuOHrpVBj/PjeQQJrLCfwP8UeNVoBOp/PEmKVdLeuHafmWA8PPcVlDbWXaupKntD4Gx flzKtXSiPso6IUtwxDu5tRIeGd6R6pubFFopS7QuvcCxgeSV8gvxhli534887FmeSEqG BAhqseQCeyzsP47n284OD64rvqaoditnHqRB3eoE3Ra85G8OItAbs5D37bnkZSRvxgTl InBgEUNwMUCVaqDU/G6v/mKhHw47fJji/Scu9ssHi31NTHxuFzE4BgG/xctTIzFAiOKj AgmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YQX8sml47RFjV0+UFD1g3dvbgVChVLgA+ZXVuKnEBDA=; b=WhECa0ZPcSWLFdy+bkr0ybdyZ8A0v95JymkGIdi6IebBUkEmm9ouX1qRu3evxqy2Or DdqUoSENhWDv8wifGSUG5nI2qBPcYEWRbEsgp1QJgVBjWDfhkEOjanpxvXBmYEHbbjJa P8jFUhj3fliJ+EbJbTrNY9UUhu38eiCnh3mTuhaqv3V5YWfCaXa5PuepD9DCONHz7VrW ByuMmG5ds6wSuO0DkCBFn448e/ORhlvgzPzHT+sEbkN/0GaSrsi2ELQdpiGhkVA4xa5k n/cJ8PQ/v0H53OSjcVYA6nU+y9pxbefhfxCWQP8Vuna38OKxPye61eMhDpJfcfull31Z 0r7A== X-Gm-Message-State: AO0yUKXQ7JFz4fva6YDGrjIjvKAJL2M9mNMA6LarWBZDRXJkVWWfbKPx TYEKdsEY7h/NhlgE8DpiS9PxNEbnxFZjzXm1LpPjDg== X-Google-Smtp-Source: AK7set+Azj58hJKWK/Ya8AP1bUvn+B4Q/Muje1+HBmI5yQDEOukhj6Yd4g0+wBXyrBrqOrmXwnU9FZ5aZyt49fskKpg= X-Received: by 2002:a17:906:a409:b0:8b1:2d36:a58e with SMTP id l9-20020a170906a40900b008b12d36a58emr1465222ejz.2.1676480839308; Wed, 15 Feb 2023 09:07:19 -0800 (PST) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Wed, 15 Feb 2023 10:07:08 -0700 Message-ID: Subject: Re: Build breakage with WITH_BEARSSL=1 To: Gordon Bergling Cc: FreeBSD Current Content-Type: multipart/alternative; boundary="000000000000e66f1a05f4c01c6a" X-Spamd-Result: default: False [-3.00 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20210112.gappssmtp.com:s=20210112]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ARC_NA(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; R_SPF_NA(0.00)[no SPF record]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::532:from]; DKIM_TRACE(0.00)[bsdimp-com.20210112.gappssmtp.com:+]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; DMARC_NA(0.00)[bsdimp.com]; TO_DN_ALL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4PH4J94Z4Qz3v9L X-Spamd-Bar: -- X-ThisMailContainsUnwantedMimeParts: N --000000000000e66f1a05f4c01c6a Content-Type: text/plain; charset="UTF-8" On Sun, Feb 12, 2023, 3:18 PM Warner Losh wrote: > > > On Sun, Feb 12, 2023 at 3:54 AM Gordon Bergling wrote: > >> Hi, >> >> I am currently seeing a build breakage when building -CURRENT with >> WITH_BEARSSL=1. >> >> The error is the following >> >> make[5]: "/boiler/nfs/src/lib/libsecureboot/local.trust.mk" line 109: >> warning: "cd /boiler/nfs/src/lib/libsecureboot && 'ls' -1 *.pem t*.asc 2> >> /dev/null" returned non-zero status >> /boiler/nfs/src/contrib/bearssl/src/rsa/rsa_i62_keygen.c:43:22: error: >> a function declaration without a prototype is deprecat ed in all versions >> of C [-Werror,-Wstrict-prototypes] >> br_rsa_i62_keygen_get() >> ^ >> void >> 1 error generated. >> --- rsa_i62_keygen.pico --- >> >> >> When disabling BEARSSL in the src.conf the build succeeds as usual. >> >> Has anyone also seen this build error. Sources are very recent and the >> src.conf is the following: >> >> WITH_EXTRA_TCP_STACKS=1 >> #WITH_BEARSSL=1 >> WITH_PIE=1 >> WITH_RETPOLINE=1 >> WITH_INIT_ALL_ZERO=1 >> WITH_OPENSSL_KTLS=1 >> WITHOUT_CLEAN=1 >> >> Any help is very appreciated. >> >> > What does the following do for you? It's a cut and pasted patch, but it > should be clear enough what to do if the mailer mangles it. > > diff --git a/lib/libbearssl/Makefile.inc b/lib/libbearssl/Makefile.inc > index dd0e242c8ef0..2af4864d8441 100644 > --- a/lib/libbearssl/Makefile.inc > +++ b/lib/libbearssl/Makefile.inc > @@ -4,4 +4,4 @@ BEARSSL?= ${SRCTOP}/contrib/bearssl > BEARSSL_SRC= ${BEARSSL}/src > > CFLAGS+= -I${BEARSSL}/inc > - > +CFLAGS+= ${NO_WDEPRECATED_NON_PROTOTYPE} > I went ahead and committed this. Please let me know if the problem persists. Warner > --000000000000e66f1a05f4c01c6a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Sun, Feb 12, 2023, 3:18 PM Warner Losh <= ;imp@bsdimp.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">

<= br>
On Sun,= Feb 12, 2023 at 3:54 AM Gordon Bergling <gbe@freebsd.org> wrote:
Hi,

I am currently seeing a build breakage when building -CURRENT with WITH_BEA= RSSL=3D1.

The error is the following

=C2=A0 make[5]: "/boiler/nfs/src/lib/libsecureboot/local.trust.= mk" line 109: warning: "cd /boiler/nfs/src/lib/libsecureboot = && 'ls'=C2=A0 =C2=A0-1 *.pem t*.asc 2> /dev/null" r= eturned non-zero status
=C2=A0 /boiler/nfs/src/contrib/bearssl/src/rsa/rsa_i62_keygen.c:43:22: erro= r: a function declaration without a prototype is deprecat=C2=A0 ed in all v= ersions of C [-Werror,-Wstrict-prototypes]
=C2=A0 br_rsa_i62_keygen_get()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0^
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 void
=C2=A0 1 error generated.
=C2=A0 --- rsa_i62_keygen.pico ---


When disabling BEARSSL in the src.conf the build succeeds as usual.

Has anyone also seen this build error. Sources are very recent and the
src.conf is the following:

WITH_EXTRA_TCP_STACKS=3D1
#WITH_BEARSSL=3D1
WITH_PIE=3D1
WITH_RETPOLINE=3D1
WITH_INIT_ALL_ZERO=3D1
WITH_OPENSSL_KTLS=3D1
WITHOUT_CLEAN=3D1

Any help is very appreciated.


What does the following do for you? It= 's a cut and pasted patch, but it should be clear enough what to do if = the mailer mangles it.

diff --git a/lib/libbearssl= /Makefile.inc b/lib/libbearssl/Makefile.inc
index dd0e242c8ef0..2af4864d= 8441 100644
--- a/lib/libbearssl/Makefile.inc
+++ b/lib/libbearssl/Ma= kefile.inc
@@ -4,4 +4,4 @@ BEARSSL?=3D ${SRCTOP}/contrib/bearssl
=C2= =A0BEARSSL_SRC=3D ${BEARSSL}/src

=C2=A0CFLAGS+=3D -I${BEARSSL}/inc-
+CFLAGS+=3D ${NO_WDEPRECATED_NON_PROTOTYPE}

I went ahead and = committed this. Please let me know if the problem persists.

Warner
--000000000000e66f1a05f4c01c6a--