From nobody Mon Jun 1 17:32:27 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gTgyM3f0nz6gPmN for ; Mon, 01 Jun 2026 17:32:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gTgyM2t2Sz44Nl for ; Mon, 01 Jun 2026 17:32:27 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780335147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=j+ZXKe6woc5ry7cl6wop9bS8Mnl9Kp0ZJWbx3PsBMDw=; b=qpTq3Twcfv4+atsSZpAKDPK+XO1KRLG39HuSQoeojZBVY57eZ91x0AlebS9HgvF/FQVyR3 um9H9TyPVH1FUJt7b+81lGcw9emig3q64ZUDDur23Dyk8v5n7WHVsYmx5Gu5vUiECQE35O BLTrAE++UfGY7jwJ68D+3/V3VBQTIrN9AFPAxOHOHaVJZWqkquvB/OCGi/FWs1HcRdJaOe smNFoPvTZCj2AwuaLhmPh0PHWYjZQuzLVoBk//PBEPxIeB+Tdm5c/ZS0g7tWcFPM5qsuVl M2cLxXxg3D35b29IJR9gVYZQiq0hj/ow8fXKKqdJxpP8zizvPVf9w0BWpjCJRw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780335147; a=rsa-sha256; cv=none; b=y1r38j+nGuZxWlng/3Yzps09U9UQadFQbE3jv7/ITf/dm9po6Mg5PtaHiJVauwN9gJd2+z djOjDnR6QfsRVcD4zzHHGxdPviWk5NYmO3Q6bc4H8gKFtECiwZQHjIqqdwbpPTy8IBIz+s N3L8+aC6eK3k4Pl7KkW0s45k6755sDNK7klHY5kdJSYuUrjAXKcVFPBbY2UyhMfo2gvb5O niOXaI5gkZLZMpopB+ConzZWzYYbkCmoEw+WziQK6a4Vc//eEg2HODQAPW6Ei9o0E+Ujr3 BceNjHy9AoMWAizpgDvq7baybXCWpkdwDms/ABD89A87u0+vl7uiR2ot0QEE3w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780335147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=j+ZXKe6woc5ry7cl6wop9bS8Mnl9Kp0ZJWbx3PsBMDw=; b=BaLVqCmgg4RjPw+Q7N3altdyIZpXgdyz4kO6e5sIBr6VANKpBkD9O9DbU6hPhh5u8zyJz9 20/3VFGcWdy69Hs73s8u8Czm7FojH3nsuGzWyGPsT8IhWHwr1lAsftxo2MX9dVzTJvIq0X twngZy3EM2jF71hXQQwNh5w7UxZgdgBJJFuCLyJgzTdHNmUsDvtVDS8l1RhjbTrkGmd0HD 5EIeqKRDq/wfw5mMb4026u91+wuplkTGQZ6pnwf1PPxTBTi69L5dkAVAL2H9X/4ThZZkCJ FPlvQ1wTtQOPnZeH7WOFYX5xD65AjZn2oiXN/k5UXKZJa3Vku6Wf6SDNK1gMKQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gTgyM2JCqznML for ; Mon, 01 Jun 2026 17:32:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1bb5e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 01 Jun 2026 17:32:27 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Christos Margiolis Subject: git: 369207a6c471 - stable/15 - virtual_oss(8): Fix buffer overflow in voss_compressor() call List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 369207a6c4713c64d2411eb96e3f0d6ddab6169e Auto-Submitted: auto-generated Date: Mon, 01 Jun 2026 17:32:27 +0000 Message-Id: <6a1dc22b.1bb5e.5a7ba644@gitrepo.freebsd.org> The branch stable/15 has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=369207a6c4713c64d2411eb96e3f0d6ddab6169e commit 369207a6c4713c64d2411eb96e3f0d6ddab6169e Author: Christos Margiolis AuthorDate: 2026-05-28 13:51:26 +0000 Commit: Christos Margiolis CommitDate: 2026-06-01 17:32:18 +0000 virtual_oss(8): Fix buffer overflow in voss_compressor() call This particular calls swaps the samples and maxchan arguments, which can cause a buffer overflow in p_ch_chain if maxchan exceeds its bounds (VMAX_CHAN). Reported by: Yuxiang Yang, Yizhou Zhao, Ao Wang, Xuewei Feng, Qi Li, and Ke Xu from Tsinghua University using GLM-5.1 from Z.ai Sponsored by: The FreeBSD Foundation MFC after: 3 days Reviewed by: emaste (cherry picked from commit 453de99b386d40754a038cc4b804f4c7a3b04624) --- usr.sbin/virtual_oss/virtual_oss/virtual_oss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/usr.sbin/virtual_oss/virtual_oss/virtual_oss.c b/usr.sbin/virtual_oss/virtual_oss/virtual_oss.c index 18af38d8e7aa..1da50979873d 100644 --- a/usr.sbin/virtual_oss/virtual_oss/virtual_oss.c +++ b/usr.sbin/virtual_oss/virtual_oss/virtual_oss.c @@ -781,8 +781,8 @@ virtual_oss_process(void *arg __unused) /* check if compressor should be applied */ voss_compressor(buffer_temp, pvp->rx_compressor_gain, - &pvp->rx_compressor_param, samples, - samples * src_chans, (1ULL << (pvp->bits - 1)) - 1ULL); + &pvp->rx_compressor_param, samples * src_chans, + src_chans, (1ULL << (pvp->bits - 1)) - 1ULL); TAILQ_FOREACH(pvc, &pvp->head, entry) {