From owner-cvs-all Tue Dec 17 10:45:13 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7C72D37B401; Tue, 17 Dec 2002 10:45:12 -0800 (PST) Received: from InterJet.dellroad.org (adsl-63-194-81-26.dsl.snfc21.pacbell.net [63.194.81.26]) by mx1.FreeBSD.org (Postfix) with ESMTP id B9EF643ED4; Tue, 17 Dec 2002 10:45:11 -0800 (PST) (envelope-from archie@dellroad.org) Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.1.1.20]) by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id KAA11055; Tue, 17 Dec 2002 10:31:52 -0800 (PST) Received: from arch20m.dellroad.org (localhost [127.0.0.1]) by arch20m.dellroad.org (8.12.6/8.12.6) with ESMTP id gBHIVefi012683; Tue, 17 Dec 2002 10:31:40 -0800 (PST) (envelope-from archie@arch20m.dellroad.org) Received: (from archie@localhost) by arch20m.dellroad.org (8.12.6/8.12.6/Submit) id gBHIVeD4012682; Tue, 17 Dec 2002 10:31:40 -0800 (PST) From: Archie Cobbs Message-Id: <200212171831.gBHIVeD4012682@arch20m.dellroad.org> Subject: Re: cvs commit: src/sys/i386/i386 i386-gdbstub.c In-Reply-To: To: Nate Lawson Date: Tue, 17 Dec 2002 10:31:40 -0800 (PST) Cc: Julian Elischer , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org X-Mailer: ELM [version 2.4ME+ PL99b (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Nate Lawson wrote: > > NOOOOOOO!!!!!!! > > previously a 'detach' would drop me back to ddb. > > > > please don't do this! (or provide a way for me to get back to ddb) > > I have backed it out. The original patch I submitted for review had this > behavior covered by an option + sysctl. The only feedback I got was that > the current behavior was considered a bug, hence the commit without any > protection. How would you prefer this work? Hmm, there seems to be some confusion (possibly on my part). What I "reviewed" and approved of was fixing the GDB stub so that when it received the 'detach' command, it would (a) go back to DDB mode instead of staying in GDB mode waiting for another GDB command, *not* (b) continue execution. Nate: did you implement (a) or (b)? I thought it was (a). Julian is objecting to (b) and I agree that would would be clearly wrong. -Archie __________________________________________________________________________ Archie Cobbs * Packet Design * http://www.packetdesign.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message