From owner-freebsd-fs@FreeBSD.ORG Mon Sep 14 16:16:14 2009 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 30DD81065693; Mon, 14 Sep 2009 16:16:14 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from esa-annu.mail.uoguelph.ca (esa-annu.mail.uoguelph.ca [131.104.91.36]) by mx1.freebsd.org (Postfix) with ESMTP id AC8618FC1A; Mon, 14 Sep 2009 16:16:13 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoEAKYIrkqDaFvK/2dsb2JhbADdIoQYBQ X-IronPort-AV: E=Sophos;i="4.44,384,1249272000"; d="scan'208";a="46238684" Received: from fraser.cs.uoguelph.ca ([131.104.91.202]) by esa-annu-pri.mail.uoguelph.ca with ESMTP; 14 Sep 2009 12:16:12 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by fraser.cs.uoguelph.ca (Postfix) with ESMTP id 9E765109C271; Mon, 14 Sep 2009 12:16:12 -0400 (EDT) X-Virus-Scanned: amavisd-new at fraser.cs.uoguelph.ca Received: from fraser.cs.uoguelph.ca ([127.0.0.1]) by localhost (fraser.cs.uoguelph.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l4a2DbWRUbBE; Mon, 14 Sep 2009 12:16:12 -0400 (EDT) Received: from muncher.cs.uoguelph.ca (muncher.cs.uoguelph.ca [131.104.91.102]) by fraser.cs.uoguelph.ca (Postfix) with ESMTP id F3FC0109C2CB; Mon, 14 Sep 2009 12:16:11 -0400 (EDT) Received: from localhost (rmacklem@localhost) by muncher.cs.uoguelph.ca (8.11.7p3+Sun/8.11.6) with ESMTP id n8EGLXP20407; Mon, 14 Sep 2009 12:21:33 -0400 (EDT) X-Authentication-Warning: muncher.cs.uoguelph.ca: rmacklem owned process doing -bs Date: Mon, 14 Sep 2009 12:21:33 -0400 (EDT) From: Rick Macklem X-X-Sender: rmacklem@muncher.cs.uoguelph.ca To: John Baldwin In-Reply-To: <200909140832.27956.jhb@freebsd.org> Message-ID: References: <20090913202350.GE2091@garage.freebsd.pl> <200909140832.27956.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-fs@freebsd.org, Pawel Jakub Dawidek Subject: Re: Review request for NFS readdirplus change. X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Sep 2009 16:16:14 -0000 On Mon, 14 Sep 2009, John Baldwin wrote: > On Sunday 13 September 2009 4:23:50 pm Pawel Jakub Dawidek wrote: >> Hi. >> >> I'm looking for a review of the following patch: >> >> http://people.freebsd.org/~pjd/patches/nfs_serv.c.3.patch >> [good stuff snipped] > > I don't think you need the trailing '\' before a split expression when > building cn_flags. Other than that I think it looks ok from what I can see > (but I am far less familiar with the NFS server than the NFS client). Also, > you might want to patch the new NFS server as well as the old one (or ask > Rick about the new one). > Looks fine to me, too (although I'm not particularily familiar with the flags for VOP_LOOKUP()). I can do a similar change to the experimental server once it goes in. rick