From owner-p4-projects@FreeBSD.ORG  Wed Oct 24 00:11:05 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 77DA216A469; Wed, 24 Oct 2007 00:11:05 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EFFE416A419
	for <perforce@freebsd.org>; Wed, 24 Oct 2007 00:11:04 +0000 (UTC)
	(envelope-from csjp@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id EF7B113C49D
	for <perforce@freebsd.org>; Wed, 24 Oct 2007 00:11:04 +0000 (UTC)
	(envelope-from csjp@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9O0B4O9032554
	for <perforce@freebsd.org>; Wed, 24 Oct 2007 00:11:04 GMT
	(envelope-from csjp@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9O0B4AW032541
	for perforce@freebsd.org; Wed, 24 Oct 2007 00:11:04 GMT
	(envelope-from csjp@freebsd.org)
Date: Wed, 24 Oct 2007 00:11:04 GMT
Message-Id: <200710240011.l9O0B4AW032541@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	csjp@freebsd.org using -f
From: "Christian S.J. Peron" <csjp@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 127983 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Oct 2007 00:11:05 -0000

http://perforce.freebsd.org/chv.cgi?CH=127983

Change 127983 by csjp@push on 2007/10/24 00:10:51

	Move where we audit the PID argument such that we unconditionally
	audit it.  This fixes a problem where the user supplies an invalid
	process ID which is > 0 which results in the PID argument not being
	audited.

Affected files ...

.. //depot/projects/trustedbsd/audit3/sys/kern/kern_sig.c#21 edit

Differences ...

==== //depot/projects/trustedbsd/audit3/sys/kern/kern_sig.c#21 (text+ko) ====

@@ -1693,6 +1693,7 @@
 	int error;
 
 	AUDIT_ARG(signum, uap->signum);
+	AUDIT_ARG(pid, uap->pid);
 	if ((u_int)uap->signum > _SIG_MAXSIG)
 		return (EINVAL);
 
@@ -1709,7 +1710,6 @@
 		PROC_UNLOCK(p);
 		return (error);
 	}
-	AUDIT_ARG(pid, uap->pid);
 	switch (uap->pid) {
 	case -1:		/* broadcast signal */
 		return (killpg1(td, uap->signum, 0, 1));