From owner-freebsd-arch@freebsd.org Thu Feb 22 01:16:29 2018 Return-Path: Delivered-To: freebsd-arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3A5EBF1462C; Thu, 22 Feb 2018 01:16:29 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D633A7E3DE; Thu, 22 Feb 2018 01:16:28 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id F25EB10A8C2; Wed, 21 Feb 2018 20:16:27 -0500 (EST) From: John Baldwin To: freebsd-arch@freebsd.org Cc: Cy Schubert , Garance A Drosehn , Mike Karels , "arch@freebsd.org" Subject: Re: ps output line length change Date: Wed, 21 Feb 2018 16:59:24 -0800 Message-ID: <3369243.YQvd3VYPi2@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) In-Reply-To: <20180221224715.E0E5410D7@spqr.komquats.com> References: <20180221224715.E0E5410D7@spqr.komquats.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Wed, 21 Feb 2018 20:16:28 -0500 (EST) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2018 01:16:29 -0000 On Wednesday, February 21, 2018 02:47:15 PM Cy Schubert wrote: > Iirc cem@ committed the original patch. Maybe someone should ask him to revert. Mike has. This thread is to determine what the consensus is. My preference is for the old behavior. > --- > Sent using a tiny phone keyboard. > Apologies for any typos and autocorrect. > Also, this old phone only supports top post. Apologies. > > Cy Schubert > or > The need of the many outweighs the greed of the few. > --- > > -----Original Message----- > From: Garance A Drosehn > Sent: 21/02/2018 11:52 > To: Mike Karels > Cc: arch@freebsd.org > Subject: Re: ps output line length change > > On 16 Feb 2018, at 19:46, Mike Karels wrote: > > > A couple of weeks ago, I sent email on the committers list proposing > > reversion of r314685 changing the output line length for ps. In > > particular, it uses unlimited line length if stdout is not a tty. > > The previous code used the tty width if any of stdout, stderr, or > > stdin was a tty. The change in r314685 has not been shipped in > > any release yet. > > > > The responses to that email all agreed with reversion. However, > > there has been some additional discussion in private email. > > Therefore, I am sending this to arch@. > > I've lost track of how many times I've said this, but I'll say it > one more: I think the change should be reverted. What the code > currently does is fine, and is flexible enough. I've written > many scripts which parse the output of 'ps', and the historical > behavior has never hampered me. And I do write scripts which > have to run on multiple unixes (in fact, most of my work is done > on systems which are not running FreeBSD). > > -- John Baldwin