From owner-cvs-all Mon Jan 13 12:22: 7 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2603637B401; Mon, 13 Jan 2003 12:22:06 -0800 (PST) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 37DCD43EB2; Mon, 13 Jan 2003 12:22:05 -0800 (PST) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.6/8.12.3) with ESMTP id h0DKM31e015771; Mon, 13 Jan 2003 13:22:03 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Mon, 13 Jan 2003 13:19:30 -0700 (MST) Message-Id: <20030113.131930.04794172.imp@bsdimp.com> To: dillon@apollo.backplane.com Cc: mux@FreeBSD.ORG, nick@garage.freebsd.pl, bde@zeta.org.au, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, luigi@FreeBSD.ORG Subject: Re: cvs commit: src/sbin/ipfw ipfw.8 ipfw2.c From: "M. Warner Losh" In-Reply-To: <200301132020.h0DKK9k3038226@apollo.backplane.com> References: <20030113190506.GF16775@elvis.mu.org> <200301132012.h0DKCp1e015631@harmony.village.org> <200301132020.h0DKK9k3038226@apollo.backplane.com> X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: <200301132020.h0DKK9k3038226@apollo.backplane.com> Matthew Dillon writes: : I like it. It isn't any more or less complex then having two conditionals : and it is more flexible. If nothing else comes up I will incorporate : this and commit it tonight. Cool. Note that I just realized that my patch has a subtlely different semantic than yours. Your SECURE3 means > 2 is verbidden, while mine is > 3 is verbidden. So long as it is clear from the docs, I don't care either way. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message