From owner-cvs-all Tue Apr 23 7:54: 7 2002 Delivered-To: cvs-all@freebsd.org Received: from espresso.q9media.com (espresso.q9media.com [216.254.138.122]) by hub.freebsd.org (Postfix) with ESMTP id A45CB37B41F; Tue, 23 Apr 2002 07:53:51 -0700 (PDT) Received: (from mike@localhost) by espresso.q9media.com (8.11.6/8.11.6) id g3NErap26866; Tue, 23 Apr 2002 10:53:36 -0400 (EDT) (envelope-from mike) Date: Tue, 23 Apr 2002 10:53:36 -0400 From: Mike Barcroft To: Mike Silbersack Cc: Garrett Wollman , "M. Warner Losh" , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern kern_descrip.c kern_exec.c src/sys/sys filedesc.h Message-ID: <20020423105336.E72727@espresso.q9media.com> References: <20020422160742.B8421@espresso.q9media.com> <20020423030714.U24733-100000@patrocles.silby.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020423030714.U24733-100000@patrocles.silby.com>; from silby@silby.com on Tue, Apr 23, 2002 at 03:10:01AM -0500 Organization: The FreeBSD Project Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Mike Silbersack writes: > On Mon, 22 Apr 2002, Mike Barcroft wrote: > > > I agree that the current solution to this problem is wrong. I think > > the most correct solution would be to fix each set[ug]id program to > > ensure that it has a working set of the basic std{in,out,err} > > descriptors by making a series of fstat() calls and watching for a > > EBADF. > > > > Best regards, > > Mike Barcroft > > But... if you go through and fix the bugs in the various set[ug]id > programs, doesn't that make the kernel change a no-op? And in that case, > what's the harm in having such a feature in the kernel? See the prior discussion; it breaks conformance to the Standard. There's no reason a conforming program couldn't use closed file descriptors to relay a message to a an exec()'d process, for instance. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message