From owner-cvs-src@FreeBSD.ORG Sun Jun 18 13:10:40 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E4C8F16A47D for ; Sun, 18 Jun 2006 13:10:40 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4E82A43D53 for ; Sun, 18 Jun 2006 13:10:39 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 35553 invoked from network); 18 Jun 2006 13:10:34 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 18 Jun 2006 13:10:34 -0000 Message-ID: <449550CF.6090507@freebsd.org> Date: Sun, 18 Jun 2006 15:10:39 +0200 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.4 (Windows/20060516) MIME-Version: 1.0 To: Maxim Konovalov References: <200606171732.k5HHWdl9086272@repoman.freebsd.org> <20060618013509.M67789@fledge.watson.org> <20060618101345.V10122@mp2.macomnet.net> <20060618091643.C67789@fledge.watson.org> <20060618123005.C12737@mp2.macomnet.net> In-Reply-To: <20060618123005.C12737@mp2.macomnet.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Robert Watson , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet tcp_input.c tcp_syncache.c tcp_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jun 2006 13:10:41 -0000 Maxim Konovalov wrote: > On Sun, 18 Jun 2006, 09:18+0100, Robert Watson wrote: > >> On Sun, 18 Jun 2006, Maxim Konovalov wrote: >> >>> On Sun, 18 Jun 2006, 01:37+0100, Robert Watson wrote: >>> >>>> On Sat, 17 Jun 2006, Andre Oppermann wrote: >>>> >>>>> Revision Changes Path >>>>> 1.299 +9 -6 src/sys/netinet/tcp_input.c >>>>> 1.87 +286 -255 src/sys/netinet/tcp_syncache.c >>>>> 1.130 +9 -6 src/sys/netinet/tcp_var.h >>>> This change appears to have broken world on all architectures by exposing >>>> the mutex data structure to usr.bin/netstat/inet.c via tcp_var.h. I'm not >>>> quite sure what the "right" solution is, but if >>> usr.bin/systat/netstat.c and usr.bin/netstat/inet.c >>> contrib/bsnmp/snmp_mibII/mibII_tcp.c as well. >>> >>> +#include fixes the build. >> But is increasing the exposure of kernel data structures to user >> space apps the right fix, or decreasing them? Andre fell into this >> trap precisely because of the leakage of kernel types into user >> space, and that's just one of several good reasons not to do it >> where it can possibly be avoided. > > Agreed. These syncache structures were only used internally by the kernel and only inside tcp_syncache.c so I now moved them there. Later they can be exposed through a sysctl and displayed by netstat. Sorry for the world breakage. -- Andre