From owner-freebsd-current Wed May 29 17:13:56 2002 Delivered-To: freebsd-current@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 931) id B48C937B400; Wed, 29 May 2002 17:13:51 -0700 (PDT) Date: Wed, 29 May 2002 17:13:51 -0700 From: "J. Mallett" To: Matthew Dillon Cc: David O'Brien , Julian Elischer , John Baldwin , FreeBSD current users Subject: Re: Seeking OK to commit KSE MIII Message-ID: <20020529171351.A5586@FreeBSD.ORG> References: <20020529124434.A2156@dragon.nuxi.com> <200205292007.g4TK71YD062671@apollo.backplane.com> <20020529152159.A82752@FreeBSD.ORG> <200205292353.g4TNrdH7063967@apollo.backplane.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <200205292353.g4TNrdH7063967@apollo.backplane.com>; from dillon@apollo.backplane.com on Wed, May 29, 2002 at 04:53:39PM -0700 Organisation: The FreeBSD Project X-Alternate-Addresses: , , , X-Affiliated-Projects: FreeBSD, xMach, ircd-hybrid-7 X-Towel: Yes Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * From Matthew Dillon > > : > :When you make the code more readable, you introduce further diffs, and you > :leave no reference against the original code of where the functional changes > :are. Either make the "base" code cleaned up by committing non-functional > :changes first, or commit against the "base" code your functional changes, > :and then clean it up. Otherwise, it's a pain in the ass to sort things out. > : > :And for what it's worth, I'm all for readability improvements in our code, I > :just also like to go and view diffs sometimes and try to figure out what's > :changed. > : > :But I think you're also right on the rule of thumb thing, if someone does not > :want to do this favor to everyone who might want to read diffs or annotate > :changes to the code and get something meaningful, that's fine. I've done it > > Oh come on, that is not what I meant at all and you know it. What is > this junk about 'not wanting to do this favor to everyone'? I never > said that. I didn't even come CLOSE to saying that or infering that. > It is complete and utter bullshit and a severe... nay, *EXTREME* twisting > of what I said. I was twisting my own words, not yours. > You missed the point entirely. Go back and READ WHAT I WROTE. I made > it pretty damn clear. I was showing a parallel set of thoughts and points of my own. -- J. Mallett FreeBSD: The Power To Serve To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message