From owner-cvs-src@FreeBSD.ORG Thu Feb 7 08:41:33 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 485C416A417; Thu, 7 Feb 2008 08:41:33 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 0420813C457; Thu, 7 Feb 2008 08:41:32 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 0CD114824B; Thu, 7 Feb 2008 03:41:32 -0500 (EST) Date: Thu, 7 Feb 2008 08:41:31 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: "Bruce M. Simpson" In-Reply-To: <47AA5925.3000008@FreeBSD.org> Message-ID: <20080207083930.Y74369@fledge.watson.org> References: <200802061540.m16FeXGD030782@repoman.freebsd.org> <47AA5925.3000008@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, Mike Silbersack , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_id.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2008 08:41:33 -0000 On Thu, 7 Feb 2008, Bruce M. Simpson wrote: > Mike Silbersack wrote: >> Note that this commit does not yet enable random IP ID >> generation by default. There are still some concerns >> that doing so will adversely affect performance. > > Random ip_id generation also breaks MANET multicast as it's currently > specified -- the ip_id field gets used for histogram based duplicate packet > detection. However, after my inveigling, Fred Templin at Boeing brought > encapsulation back into the proposal on the table. > > So some way to turn this stuff off on a per-interface basis is probably > going to be needed later on for mobile stuff... We also have much more general problems with our ip_id code -- using a global IP ID counter or random generator breaks down as the packet rate goes up, causing problems for NFS over UDP and other UDP applications with large packet sizes. We need to adopt some sort of host-based approach, presumably with a fallback to global when we don't want to commit state storage for a host (i.e., for RST's/SYN cookies, or even TCP generally). There's a comment in the Linux IP ID code regarding PPTP also expecting IP IPs to behave in a more historical way as well. Robert N M Watson Computer Laboratory University of Cambridge