From nobody Tue Sep 17 08:27:38 2024 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4X7FKh6nd3z5WpMQ for ; Tue, 17 Sep 2024 08:28:24 +0000 (UTC) (envelope-from herbert@gojira.at) Received: from mail.bsd4all.net (mail.bsd4all.net [94.130.200.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail.bsd4all.net", Issuer "E5" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4X7FKh3zhhz4rGG; Tue, 17 Sep 2024 08:28:24 +0000 (UTC) (envelope-from herbert@gojira.at) Authentication-Results: mx1.freebsd.org; none Date: Tue, 17 Sep 2024 10:27:38 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=gojira.at; s=mail202005; t=1726561696; bh=HrAedRmuz+CMFnqFrtU8UQ4YeRvApeDmTxfSLwn+KrQ=; h=Date:Message-ID:From:To:Cc:Subject:MIME-Version:Content-Type; b=ie0pXKS1Q5rUuBB3H9Z7CuHmEWy7B3hnwPST16c9yocGmLvI++4mGBWSoylVD9rJ3 /lkOKU1gT/3DrZTjll8qFHDMvUqukuD12RjcJqvA6KaL3ij5HvdsMatnylB3aPx/0l zStHC7H3xneisGmQu6poLqonB7Oh6cSvo7g03Y8uZn/jy24kD/FPUaLZ1Uce4PAh3A MezzbXMgYS7Eh22c1jqRgWJvwb/gv8WsFqMbvnaXB+eOKoUouzx8BbvpV8cU6tXvJ/ dBtlSB/pUN4+7lQ8YBT+J0YkAX7rdaQqvtVqHSzJ/iFKob6ujgypHOwJw/f5YAI6Kj 4Yyy3Q/KW7Jog== Message-ID: <87wmja3csl.wl-herbert@gojira.at> From: "Herbert J. Skuhra" To: Kristof Provost Cc: current@freebsd.org Subject: Re: git: 80eb861dc2a7 - main - pfctl: lex <=, >=, and != into a single token In-Reply-To: <202409161305.48GD5SMG020938@gitrepo.freebsd.org> References: <202409161305.48GD5SMG020938@gitrepo.freebsd.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/31.0 Mule/6.0 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:24940, ipnet:94.130.0.0/16, country:DE] X-Rspamd-Queue-Id: 4X7FKh3zhhz4rGG On Mon, 16 Sep 2024 15:05:28 +0200, Kristof Provost wrote: > > The branch main has been updated by kp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=80eb861dc2a7960e1acc74796cf0c937472a5dba > > commit 80eb861dc2a7960e1acc74796cf0c937472a5dba > Author: Kristof Provost > AuthorDate: 2024-08-29 10:08:32 +0000 > Commit: Kristof Provost > CommitDate: 2024-09-16 11:48:58 +0000 > > pfctl: lex <=, >=, and != into a single token > > lex <=, >=, and != into a single token for correctness and to reduce the > lookahead in the parser > ok henning otto > > Reviewed by: zlei > Obtained from: OpenBSD, deraadt , e6e3ecf338 > Sponsored by: Rubicon Communications, LLC ("Netgate") > Differential Revision: https://reviews.freebsd.org/D46582 > --- > sbin/pfctl/parse.y | 20 ++++++++++++++------ > 1 file changed, 14 insertions(+), 6 deletions(-) Does this commit break pf on arm64? # pfctl -f /etc/pf.conf pfctl: failed to add host: Invalid argument Simple pf.conf loads but # pfctl -s rules pass in all flags S/SA keep state pass out all flags S/SA keep state Abort trap (core dumped) -- Herbert