From owner-svn-ports-head@freebsd.org Mon Jul 29 03:46:07 2019 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 163DABC266; Mon, 29 Jul 2019 03:46:07 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 1AF718BF9B; Mon, 29 Jul 2019 03:46:04 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id rwbkhdv9jSrVcrwbmhIk42; Sun, 28 Jul 2019 21:45:58 -0600 X-Authority-Analysis: v=2.3 cv=L5ZjvNb8 c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=0o9FgrsRnhwA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=eJ0jARj3UOHYAHw6uekA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id DACF4132; Sun, 28 Jul 2019 20:45:55 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id x6T3jtM0004693; Sun, 28 Jul 2019 20:45:55 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id x6T3jtV8004690; Sun, 28 Jul 2019 20:45:55 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201907290345.x6T3jtV8004690@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Piotr Kubaj cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r507528 - head/security/krb5-devel In-reply-to: <201907282008.x6SK8W16025473@repo.freebsd.org> References: <201907282008.x6SK8W16025473@repo.freebsd.org> Comments: In-reply-to Piotr Kubaj message dated "Sun, 28 Jul 2019 20:08:32 -0000." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 28 Jul 2019 20:45:55 -0700 X-CMAE-Envelope: MS4wfATch8cfdu+JCODB95/8YiscaEZPc3Lasen+W12Uq5PAagStqR46p4PYTEO4QwYZPW9vagdGWfi8jnxxcirlGlaga7rNG9qJXFrtMd/ugvjP0/k4ZTMp ESEr3gedIBhSKTEpfklAEAV0A9sfTMDNBLSfdJDWb9kY0Xof10YA6dHzrmAWwZII5vdSqVOdVa/C8A1TjF0use6OqecVZFh31snJXGlGt+FeRhl6amP0yOMC iMuzjEJQ6qOEDTsuqelR6bKw2nO5hTXCsgXBcJuXYWWzPYf0kpkI2y71XOUGc6fD X-Rspamd-Queue-Id: 1AF718BF9B X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-4.91 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; MV_CASE(0.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; REPLYTO_EQ_FROM(0.00)[]; IP_SCORE(-2.38)[ip: (-6.09), ipnet: 64.59.128.0/20(-3.21), asn: 6327(-2.50), country: CA(-0.09)]; MX_GOOD(-0.01)[cached: spqr.komquats.com]; NEURAL_HAM_SHORT(-0.94)[-0.938,0]; RCVD_IN_DNSWL_NONE(0.00)[137.136.59.64.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-0.99)[-0.987,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; RCVD_TLS_LAST(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.zen.spamhaus.org : 127.0.0.11] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jul 2019 03:46:07 -0000 In message <201907282008.x6SK8W16025473@repo.freebsd.org>, Piotr Kubaj writes: > Author: pkubaj > Date: Sun Jul 28 20:08:31 2019 > New Revision: 507528 > URL: https://svnweb.freebsd.org/changeset/ports/507528 > > Log: > security/krb5-devel: fix build with GCC-based architectures > > C11 compiler is necessary: > edwards25519_fiat.h:14: error: expected '=', ',', ';', 'asm' or '__attribut > e__' before 'fiat_25519_int128' > > Approved by: mentors (implicit approval) This wasn't approved by maintainer. As this is fixit, at least a heads up email would have been appreciated (as linimon@ does) -- and I would have given you additional things to check too. > > Modified: > head/security/krb5-devel/Makefile > > Modified: head/security/krb5-devel/Makefile > ============================================================================= > = > --- head/security/krb5-devel/Makefile Sun Jul 28 19:44:26 2019 (r50752 > 7) > +++ head/security/krb5-devel/Makefile Sun Jul 28 20:08:31 2019 (r50752 > 8) > @@ -29,8 +29,8 @@ USE_PERL5= build > USE_LDCONFIG= yes > USE_CSTD= gnu99 > GNU_CONFIGURE= yes > -USES= autoreconf cpe gmake localbase perl5 libtool:bu > ild \ > - gssapi:bootstrap,mit pkgconfig ssl > +USES= autoreconf compiler:c11 cpe gmake localbase per > l5 \ > + libtool:build gssapi:bootstrap,mit pkgconfig ssl > CONFIGURE_ARGS?= --enable-shared --without-system-verto \ > --disable-rpath --localstatedir="${PREFIX}/var" > CONFIGURE_ENV= INSTALL="${INSTALL}" INSTALL_LIB="${INSTALL_LIB > }" YACC="${YACC}" > -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.