From owner-freebsd-ports@FreeBSD.ORG  Wed Jan 21 12:40:08 2004
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 683)
	id 7599516A4CF; Wed, 21 Jan 2004 12:40:08 -0800 (PST)
Date: Wed, 21 Jan 2004 12:40:08 -0800
From: Eivind Eklund <eivind@FreeBSD.org>
To: Oliver Eikemeier <eikemeier@fillmore-labs.com>
Message-ID: <20040121204008.GD16950@FreeBSD.org>
References: <1074621945.757.63.camel@gyros> <400D7077.30009@fillmore-labs.com>
	<1074622845.757.69.camel@gyros> <20040120184123.GI94636@FreeBSD.org>
	<1074637133.757.128.camel@gyros> <400EA9E4.3040004@fillmore-labs.com>
	<1074704419.768.41.camel@gyros> <400EBAF2.5040400@fillmore-labs.com>
	<1074708900.768.70.camel@gyros> <400EE172.50703@fillmore-labs.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <400EE172.50703@fillmore-labs.com>
User-Agent: Mutt/1.4.1i
cc: ports@FreeBSD.org
cc: Adam Weinberger <adamw@FreeBSD.org>
cc: Joe Marcus Clarke <marcus@FreeBSD.org>
cc: Kris Kennaway <kris@obsecurity.org>
Subject: Re: OPTIONSFILE path [HEADS UP: New bsd.*.mk changes]
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Jan 2004 20:40:08 -0000

On Wed, Jan 21, 2004 at 09:30:42PM +0100, Oliver Eikemeier wrote:
> FYI: PR ports/61683: enhanced OPTIONS handling
>  http://www.freebsd.org/cgi/query-pr.cgi?pr=61683

I didn't get the comment for UNIQUENAME in that patch ("is set to
${LATEST_LINK} when set, $PKGNAMEPREFIX}${PORTNAME} else") when
I first read it - I only got it when I looked at the code.

Maybe
	this is set to ${LATEST_LINK} when LATEST_LINK is set,
	and to ${PKGNAMEPREFIX}${PORTNAME} otherwise.
?

Apart from this, the patch looks good to me.

Eivind.