From owner-cvs-all@FreeBSD.ORG Wed Oct 6 00:40:41 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A99A616A4F7; Wed, 6 Oct 2004 00:40:41 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9C5A343D53; Wed, 6 Oct 2004 00:40:41 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i960efdU089442; Wed, 6 Oct 2004 00:40:41 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i960efqj089441; Wed, 6 Oct 2004 00:40:41 GMT (envelope-from davidxu) Message-Id: <200410060040.i960efqj089441@repoman.freebsd.org> From: David Xu Date: Wed, 6 Oct 2004 00:40:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys proc.h src/sys/kern kern_exec.c kern_thread.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Oct 2004 00:40:41 -0000 davidxu 2004-10-06 00:40:41 UTC FreeBSD src repository Modified files: sys/sys proc.h sys/kern kern_exec.c kern_thread.c Log: In original kern_execve() code, at the start of the function, it forces all other threads to suicide, problem is execve() could be failed, and a failed execve() would change threaded process to unthreaded, this side effect is unexpected. The new code introduces a new single threading mode SINGLE_BOUNDARY, in the mode, all threads should suspend themself at user boundary except the singler. we can not use SINGLE_NO_EXIT because we want to start from a clean state if execve() is successful, suspending other threads at unknown point and later resuming them from there and forcing them to exit at user boundary may cause the process to start from a dirty state. If execve() is successful, current thread upgrades to SINGLE_EXIT mode and forces other threads to suicide at user boundary, otherwise, other threads will be resumed and their interrupted syscall will be restarted. Reviewed by: julian Revision Changes Path 1.254 +46 -12 src/sys/kern/kern_exec.c 1.203 +60 -23 src/sys/kern/kern_thread.c 1.409 +5 -3 src/sys/sys/proc.h