From owner-freebsd-current@freebsd.org Wed Aug 22 03:27:01 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C8792108A0BE; Wed, 22 Aug 2018 03:27:01 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 799A37E00E; Wed, 22 Aug 2018 03:27:01 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from mail-io0-f171.google.com (mail-io0-f171.google.com [209.85.223.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) (Authenticated sender: mmacy) by smtp.freebsd.org (Postfix) with ESMTPSA id 3FC7610AD8; Wed, 22 Aug 2018 03:27:01 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: by mail-io0-f171.google.com with SMTP id l7-v6so410844iok.6; Tue, 21 Aug 2018 20:27:01 -0700 (PDT) X-Gm-Message-State: AOUpUlERxQMew6WVd9LpaWXzQ0QbmEmKiWCQyae09ti62VzMdwQFXKDw 4THdajwndBu6zqUPSC6fNlal98APKgLuhpm0K4U= X-Google-Smtp-Source: AA+uWPwSVUNXx50T+vUJSt4grwvC4Uutr7fM4srzBnVOgh4I5teL/eXLgTjEQ98TEq8Ly/QUcz+CJ0CvJKMErAXCZCI= X-Received: by 2002:a6b:ed11:: with SMTP id n17-v6mr19517651iog.132.1534908420727; Tue, 21 Aug 2018 20:27:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Matthew Macy Date: Tue, 21 Aug 2018 20:26:50 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Native Encryption for ZFS on FreeBSD CFT To: Alan Somers Cc: FreeBSD CURRENT , Sean Fagan , freebsd-fs Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2018 03:27:02 -0000 On Tue, Aug 21, 2018 at 20:22 Alan Somers wrote: > On Tue, Aug 21, 2018 at 9:13 PM Sean Fagan wrote: > >> On Aug 21, 2018, at 8:11 PM, Alan Somers wrote: >> > The last time I looked (which was a long time ago), Oracle's ZFS >> encryption looked extremely vulnerable to watermarking attacks. Did >> anybody ever fix that? >> >> This isn=E2=80=99t Oracle=E2=80=99s implementation, but I don=E2=80=99t = know how compatible or >> not it is with it. >> >> Sean. >> > > It wasn't just an implementation problem, it was in the design. IIRC, > Oracle's encryption allowed encrypted blocks to be deduplicated. There's > pretty much no way to defend against watermarking attacks with such a > design. Does the new encryption design have the same flaw? > I would ask the original developer that question (see the commit I linked to). The current dedup Implementation is terrible, so there are very few users of it. -M > > -Alan >