From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Feb 1 13:31:50 2015 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 10BAAD13 for ; Sun, 1 Feb 2015 13:31:50 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D0D76695 for ; Sun, 1 Feb 2015 13:31:49 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t11DVnmW017375 for ; Sun, 1 Feb 2015 13:31:49 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 197241] [PATCH] sysutils/lsof fix build on systems without /etc/make.conf Date: Sun, 01 Feb 2015 13:31:49 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: riggs@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Feb 2015 13:31:50 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197241 Bug ID: 197241 Summary: [PATCH] sysutils/lsof fix build on systems without /etc/make.conf Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: freebsd-ports-bugs@FreeBSD.org Reporter: riggs@FreeBSD.org CC: ler@lerctr.org CC: ler@lerctr.org Flags: maintainer-feedback?(ler@lerctr.org) Created attachment 152436 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=152436&action=edit Patch to fix build on systems without /etc/make.conf Terry Kennedy noticed that on plain vanilla installations of FreeBSD lsof does not build due to picking up CFLAGS incorrectly. We tracked this down to a bug in lsof's configure script checking for the existence of make.conf and then deriving CFLAGS based on the result. It turns out that it does not do anything with make.conf's content, but its absence causes the configure script to select CFLAGS erroneously. The attached micro-patch ensures that the same algorithm is always used to select CFLAGS, independently of make.conf's existence on the target machine. Tested on 8.4, 9.3 (i386) and 10.1 (amd64, armv6). @Maintainer: Do you approve? --- Comment #1 from Bugzilla Automation --- Maintainer CC'd -- You are receiving this mail because: You are the assignee for the bug.