Date: Sun, 01 Feb 2015 13:31:49 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 197241] [PATCH] sysutils/lsof fix build on systems without /etc/make.conf Message-ID: <bug-197241-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197241 Bug ID: 197241 Summary: [PATCH] sysutils/lsof fix build on systems without /etc/make.conf Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: freebsd-ports-bugs@FreeBSD.org Reporter: riggs@FreeBSD.org CC: ler@lerctr.org CC: ler@lerctr.org Flags: maintainer-feedback?(ler@lerctr.org) Created attachment 152436 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=152436&action=edit Patch to fix build on systems without /etc/make.conf Terry Kennedy <terry@tmk.com> noticed that on plain vanilla installations of FreeBSD lsof does not build due to picking up CFLAGS incorrectly. We tracked this down to a bug in lsof's configure script checking for the existence of make.conf and then deriving CFLAGS based on the result. It turns out that it does not do anything with make.conf's content, but its absence causes the configure script to select CFLAGS erroneously. The attached micro-patch ensures that the same algorithm is always used to select CFLAGS, independently of make.conf's existence on the target machine. Tested on 8.4, 9.3 (i386) and 10.1 (amd64, armv6). @Maintainer: Do you approve? --- Comment #1 from Bugzilla Automation <bugzilla@FreeBSD.org> --- Maintainer CC'd -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-197241-13>