From owner-freebsd-current@freebsd.org Fri Jan 1 22:58:04 2021 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9B84F4D6DBC for ; Fri, 1 Jan 2021 22:58:04 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D70mW30Klz4T90 for ; Fri, 1 Jan 2021 22:58:03 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qv1-xf34.google.com with SMTP id j18so10423256qvu.3 for ; Fri, 01 Jan 2021 14:58:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FO5FbhP/0LOi7xVnWgRQYY6MrjR1uPMokw7wpjbLjUw=; b=LKLxq+ZrxXnX+kLPGIMMD3ruFGu8Y/QBqN4cAqUmVsgQpDX4WJ78kPsrj39zATFO4d Lg21gRFGVHEdZocxnXoTsa+HHfDRCTZ7nh9lvSpeQXSbJJcwyW5v6w3ggUJU+7qpeq1G yEE+iHiGnIxKzQR+eZKDDdhtLhyytMOBRjFVxNc1z2saaPyI65MVuJ0WU4JKlfj3KmWZ XBJ2oyi8hri+MRxlH5hbU+wIu9FzGR613NIPftNwfqokDbVSnpbf7kLsMWUY6LTt6Stt oVbXsx0f1AtmJEnNEkuAqYFT1UaCyxaJuMgoZFyVKu3YOKSq7KTtRAB1SOvpSd8QEYva ni0g== X-Gm-Message-State: AOAM533mbI/kst/wswfC99gGp3woDSoo8LYptu6YUU9DAuz9oslowk0X SrMk9W5xXMECkIPKLeOewNuZtsDURJdmZ9fhg9y/jQ== X-Google-Smtp-Source: ABdhPJzPtbj7rGpl8W9hkB53MSNIYt2j0ZW9qzLcuXQFD4w6CK3j0blQT3mhclEm8CaxS1nT/C+Zjru1Ov8JNFW0e2o= X-Received: by 2002:a05:6214:16cb:: with SMTP id d11mr66567539qvz.62.1609541882299; Fri, 01 Jan 2021 14:58:02 -0800 (PST) MIME-Version: 1.0 References: <5d56280e-a8dd-b28d-7039-f8fe0bc0cd6f@freebsd.org> In-Reply-To: From: Warner Losh Date: Fri, 1 Jan 2021 15:57:50 -0700 Message-ID: Subject: Re: Enabling AESNI by default To: =?UTF-8?Q?Mina_Gali=C4=87?= Cc: Allan Jude , FreeBSD Current X-Rspamd-Queue-Id: 4D70mW30Klz4T90 X-Spamd-Bar: -- X-Spamd-Result: default: False [-3.00 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000]; TAGGED_RCPT(0.00)[freebsd]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::f34:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::f34:from]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::f34:from]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; MAILMAN_DEST(0.00)[freebsd-current]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jan 2021 22:58:04 -0000 On Fri, Jan 1, 2021, 1:40 PM Mina Gali=C4=87 wrote: > On Thursday, December 31st, 2020 at 20:51, Allan Jude < > allanjude@freebsd.org> wrote: > > > We've had the AESNI module for quite a few years now, and it has not > caused any problems. > > > > I am wondering if there are any objections to including it in GENERIC, > so that users get the benefit without having to have the "tribal knowledg= e" > that 'to accelerate kernel crypto (GELI, ZFS, IPSEC, etc), you need to lo= ad > aesni.ko' > > This tribal knowledge is encoded in bsdinstall when you setup encryption > on zfs: > > https://cgit.freebsd.org/src/tree/usr.sbin/bsdinstall/scripts/zfsboot#n12= 07 Even so, adding to GENERIC is fine. Warner > > Mina > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org= " >