From owner-freebsd-current@FreeBSD.ORG Thu Apr 22 18:24:06 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 270761065670; Thu, 22 Apr 2010 18:24:06 +0000 (UTC) (envelope-from gordon.tetlow@gmail.com) Received: from mail-pz0-f172.google.com (mail-pz0-f172.google.com [209.85.222.172]) by mx1.freebsd.org (Postfix) with ESMTP id E3A2F8FC1A; Thu, 22 Apr 2010 18:24:05 +0000 (UTC) Received: by pzk2 with SMTP id 2so5798956pzk.27 for ; Thu, 22 Apr 2010 11:24:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:received:message-id:subject :from:to:cc:content-type; bh=LwJ4gOUjCyWei7eKM3yL9Gh1mkGUGlWxyvalPiokT5s=; b=A34AXd+bYka0+SRcWFuBy9j22lob/4TulEIWekkvFZ/OCPluT4DWs6SWHHaAy9nfF6 npyCygmFlf/HMH4yKVX3/FXqP7bcUubvfDPjcCTLj3C8NTfXO12TedGGamOaXhtkl1lt bpSNPnSX20s2pk+Ag+l0ME40zycD0y/qdK6KA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=g3dDbK8Q6rctdzMCVaKls4VKRmp+cUdUTuKgGliKRVbsB/7vhCb0NADiJaImsMtroP B5BSrRnFrcGEbvKbwJ4fTOxnKOEbbYwtkVDYdiFnkfN2B2EAySZHSySdmkn1O40ClCFH Wyqo9FQhJ5XR9VlwX6jREvnCgUU2FkQAdCu4A= MIME-Version: 1.0 Sender: gordon.tetlow@gmail.com Received: by 10.140.194.12 with HTTP; Thu, 22 Apr 2010 11:24:04 -0700 (PDT) In-Reply-To: <201004220926.23593.jhb@freebsd.org> References: <201004220926.23593.jhb@freebsd.org> Date: Thu, 22 Apr 2010 11:24:04 -0700 X-Google-Sender-Auth: 31f5439c363220bd Received: by 10.141.214.22 with SMTP id r22mr9883717rvq.165.1271960645154; Thu, 22 Apr 2010 11:24:05 -0700 (PDT) Message-ID: From: Gordon Tetlow To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-current@freebsd.org Subject: Re: newsyslog patch implementing file includes X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Apr 2010 18:24:06 -0000 On Thu, Apr 22, 2010 at 6:26 AM, John Baldwin wrote: > This is a great feature! One suggestion, I think this text in the new > manpage > isn't quite right: > > Name of the system log file to be archived, the literal string "default", > or "include". > > I think it's ambiguous about "include" also being a literal string. Two > possible suggestions: > > Name of the system log file to be archived, or one of the literal strings > "default" or "include". > > Name of the system log file to be archived, the literal string "default", > or the literal string "include". > I took your first suggestion and updated the patch. Thanks, Gordon