From owner-svn-src-all@FreeBSD.ORG Tue Apr 20 05:31:54 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6A98F106566C; Tue, 20 Apr 2010 05:31:54 +0000 (UTC) (envelope-from luigi@onelab2.iet.unipi.it) Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238]) by mx1.freebsd.org (Postfix) with ESMTP id 29E2A8FC0C; Tue, 20 Apr 2010 05:31:53 +0000 (UTC) Received: by onelab2.iet.unipi.it (Postfix, from userid 275) id C446773098; Tue, 20 Apr 2010 07:42:27 +0200 (CEST) Date: Tue, 20 Apr 2010 07:42:27 +0200 From: Luigi Rizzo To: Julian Elischer Message-ID: <20100420054227.GA62058@onelab2.iet.unipi.it> References: <201004191511.o3JFBjLj036350@svn.freebsd.org> <4BCC7E64.4040200@FreeBSD.org> <4BCCDCC9.2070604@elischer.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4BCCDCC9.2070604@elischer.org> User-Agent: Mutt/1.4.2.3i Cc: svn-src-head@FreeBSD.org, Luigi Rizzo , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, Robert Noland Subject: Re: svn commit: r206843 - head/sbin/ipfw X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Apr 2010 05:31:54 -0000 On Mon, Apr 19, 2010 at 03:44:25PM -0700, Julian Elischer wrote: > On 4/19/10 9:01 AM, Robert Noland wrote: > > > > > >Luigi Rizzo wrote: > > > [...] > > >Index: sbin/ipfw/ipfw2.c > >=================================================================== > >--- sbin/ipfw/ipfw2.c (revision 206844) > >+++ sbin/ipfw/ipfw2.c (working copy) > >@@ -326,7 +326,7 @@ > >#ifdef TCC > >#define U64_FMT "I64" > >#else > >-#define U64_FMT "llu" > >+#define U64_FMT "ju" > >#endif > >uint64_t d; > > believe there is a posix define for this? > (though I can't remember it right now). the reason for the above code is that MSVC (actually, the DLL in Windows -- so the problem exists also for TCC on Windows) does not support %llu or %ju but only %I64 and that is why i need this ugly code (to tell the truth i am not even sure that the various libc for embedded platforms support %ju). cheers luigi