From owner-cvs-src-old@FreeBSD.ORG Sat Aug 28 00:34:41 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6B1B71065698 for ; Sat, 28 Aug 2010 00:34:41 +0000 (UTC) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 3D2B28FC1C for ; Sat, 28 Aug 2010 00:34:41 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id o7S0Yf99077751 for ; Sat, 28 Aug 2010 00:34:41 GMT (envelope-from yongari@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.4/8.14.4/Submit) id o7S0Yf1m077750 for cvs-src-old@freebsd.org; Sat, 28 Aug 2010 00:34:41 GMT (envelope-from yongari@repoman.freebsd.org) Message-Id: <201008280034.o7S0Yf1m077750@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to yongari@repoman.freebsd.org using -f From: Pyun YongHyeon Date: Sat, 28 Aug 2010 00:34:22 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/e1000 if_em.c if_em.h if_igb.c if_igb.h if_lem.c if_lem.h src/sys/dev/ixgb if_ixgb.c if_ixgb.h src/sys/dev/ixgbe ixgbe.c ixgbe.h X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Aug 2010 00:34:41 -0000 yongari 2010-08-28 00:34:22 UTC FreeBSD src repository Modified files: sys/dev/e1000 if_em.c if_em.h if_igb.c if_igb.h if_lem.c if_lem.h sys/dev/ixgb if_ixgb.c if_ixgb.h sys/dev/ixgbe ixgbe.c ixgbe.h Log: SVN rev 211913 on 2010-08-28 00:34:22Z by yongari Do not allocate multicast array memory in multicast filter configuration function. For failed memory allocations, em(4)/lem(4) called panic(9) which is not acceptable on production box. igb(4)/ixgb(4)/ix(4) allocated the required memory in stack which consumed 768 bytes of stack memory which looks too big. To address these issues, allocate multicast array memory in device attach time and make multicast configuration success under any conditions. This change also removes the excessive use of memory in stack. Reviewed by: jfv Revision Changes Path 1.54 +14 -8 src/sys/dev/e1000/if_em.c 1.15 +2 -0 src/sys/dev/e1000/if_em.h 1.58 +16 -1 src/sys/dev/e1000/if_igb.c 1.15 +2 -0 src/sys/dev/e1000/if_igb.h 1.9 +14 -8 src/sys/dev/e1000/if_lem.c 1.3 +2 -0 src/sys/dev/e1000/if_lem.h 1.29 +16 -1 src/sys/dev/ixgb/if_ixgb.c 1.12 +2 -0 src/sys/dev/ixgb/if_ixgb.h 1.38 +16 -1 src/sys/dev/ixgbe/ixgbe.c 1.18 +2 -0 src/sys/dev/ixgbe/ixgbe.h