From nobody Tue Dec 14 21:42:49 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8B33618E7081; Tue, 14 Dec 2021 21:42:53 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JDBgd1qd5z3pNh; Tue, 14 Dec 2021 21:42:53 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.codepro.be", Issuer "R3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 09C816CC7; Tue, 14 Dec 2021 21:42:53 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 8084E226FD; Tue, 14 Dec 2021 22:42:50 +0100 (CET) From: Kristof Provost To: Gleb Smirnoff Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: eb93b99d6986 - main - in_pcb: delay crfree() down into UMA dtor Date: Tue, 14 Dec 2021 22:42:49 +0100 X-Mailer: MailMate (1.14r5852) Message-ID: <28AE53F1-2B22-444B-B1EC-1600FA741FE2@FreeBSD.org> In-Reply-To: <202112051847.1B5Il2GP030287@gitrepo.freebsd.org> References: <202112051847.1B5Il2GP030287@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=_MailMate_08E64701-C3C6-422E-84B5-8215067F1362_=" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1639518173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PMqATRY2gojE4KAvNlJG3zIwhZ2XygHb4Bq3FREnSwQ=; b=DoJGAnVaNFw2c88bjnxoxS1ywVfvQyORdz6fM8xJWehuTI35pk42PRayfb7SCvZLZh8sr+ bx8+kU65rJ67XhUghkSi5LLXoIW5p1VI8zx6druVM9VJbjkOlEw8ur37/z6K3FN4it5JUI BtaHkai1GR75R15CfvunGEZ1vsNRGRAmrcd6NQeraAhDp6YlGOTdCh6eKpc6GgpUxNOj4O E2M7N1GR6vTHBdRnJQXX/nhMACv4Mc3fWcGWfEf+JICjad+FEhAiUNwLHtIayLiJZpqnyZ 4U9hIu655kESebHyHQjEH5+ye4OP4zELGl93DKDBfZwoIa0YZL1EgqOm9uzOXg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1639518173; a=rsa-sha256; cv=none; b=rq2SCmlluSO/Qtl6m3Cvh8IjoFwKUR7xRrplbwlZOe2DvmfTWCjbAGWNdJW9frFf7L4+Kw 2K3qV3oHSugnif55/fHZ/1prmoFBa0aDRzdw5t4a/zq1l9xEuhXNWfYd3Vo8Ir0minc+cZ S1Tp/mszk8wCGX7KKwlS9KUY/34g3eVROqTt6TuiG9i94bRratA04VNVwW/edZWC8nbqV6 v3lyS4YC7I5/5dZJqQs9BL1hNogwr9R/WwHrx2UoEfN5+sQwhygCejzug5TyEhRoZiaNqb M5/zbNLn31IBL1A4JzzpVZ0U/8xyk3z4T/3zGPMYN3eqF11k8/ZEWuZU6rCUaA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N --=_MailMate_08E64701-C3C6-422E-84B5-8215067F1362_= Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 5 Dec 2021, at 19:47, Gleb Smirnoff wrote: > The branch main has been updated by glebius: > > URL: = > https://cgit.FreeBSD.org/src/commit/?id=3Deb93b99d698674e3b1cc7139fda98= e2b175b8c5b > > commit eb93b99d698674e3b1cc7139fda98e2b175b8c5b > Author: Gleb Smirnoff > AuthorDate: 2021-12-05 16:47:24 +0000 > Commit: Gleb Smirnoff > CommitDate: 2021-12-05 18:46:37 +0000 > > in_pcb: delay crfree() down into UMA dtor > > inpcb lookups, which check inp_cred, work with pcbs that = > potentially went > through in_pcbfree(). So inp_cred should stay valid until SMR = > guarantees > its invisibility to lookups. > > While here, put the whole inpcb destruction sequence of = > in_pcbfree(), > inpcb_dtor() and inpcb_fini() sequentially. > > Submitted by: markj > Differential revision: https://reviews.freebsd.org/D33273 > For some reason it looks like this commit causes jails to fail to get = fully cleaned up. I can reproduce that trivially with `cd /usr/tests/sys/net ; kyua test = if_bridge_test:bridge_transmit_ipv4_unicast ; jls -na`. Note the jails in dying state. The jails created by that test never go away. It=E2=80=99s as if = `crfree(inp->inp_cred);` doesn=E2=80=99t actually get called. And indeed,= it = looks like inpcb_dtor() does not get called at all. Does Kristof --=_MailMate_08E64701-C3C6-422E-84B5-8215067F1362_=--