From owner-svn-src-all@freebsd.org Tue Jul 16 17:36:44 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F2833B5DB1; Tue, 16 Jul 2019 17:36:44 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-yb1-f193.google.com (mail-yb1-f193.google.com [209.85.219.193]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 740076B7FB; Tue, 16 Jul 2019 17:36:44 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by mail-yb1-f193.google.com with SMTP id x188so3507087yba.8; Tue, 16 Jul 2019 10:36:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=B1aNIa7W6eoGSUR6iwo26GFNuUAnSGwcaGg5It/55Zc=; b=LlmS7PgF5vL6GyYTF7uUUevxDwAmB8Q4lfnDXtDCwzOtY4OOYaBQhPvW7uFDyUXXrO YHct75avQ91JjNSWraGldPd9zYdkCbckO9FZzfdt1vN+p+z6OZhSy58N/lx2CbFNdw7S xm9eg7WX8v3c9q6SLAe6yCkFlbiUDQxZW8JS6P2yGIsqGT/mbMIsvbtVZOkv/pEh0lnA Ym32FrjNYOQSyqWMlNSk62WyRn8xASNeno9r66+OeSLlRiwQ9ko8I0+o9+oTgBNryNQF 2PCvHEzbTjD0tuAP8DPxJxzkK5zI7hImQOcf5Mw5vmluExTSsSuZuy7hIpz/c4EXzfTZ MK/g== X-Gm-Message-State: APjAAAWjqWwokJeAmVbPNl/+Xg6u4r8iqzsIaYpXuSL1sG8NBxvwBS59 PVZZwHGPS8XijWAoEdKpbLGX4BML2JiDThgkK18tdCJb X-Google-Smtp-Source: APXvYqySJATmri3/iQZmKbWmsNiQoHWLvgzfpbI5Qg3ucp1AAn4CU/2y/rrEEXLy7ii4+lUWbwsFDvU7bg2G26toyxA= X-Received: by 2002:a25:1d42:: with SMTP id d63mr9364258ybd.405.1563298597899; Tue, 16 Jul 2019 10:36:37 -0700 (PDT) MIME-Version: 1.0 References: <201907161552.x6GFqlU5013936@repo.freebsd.org> <94d937ee-e121-8882-9859-7d477e18beb4@FreeBSD.org> In-Reply-To: <94d937ee-e121-8882-9859-7d477e18beb4@FreeBSD.org> From: Li-Wen Hsu Date: Wed, 17 Jul 2019 01:36:26 +0800 Message-ID: Subject: Re: svn commit: r350044 - in stable/12: share/man/man4 sys/dev/gpio To: Andriy Gapon Cc: src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 740076B7FB X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of lwhsufreebsd@gmail.com designates 209.85.219.193 as permitted sender) smtp.mailfrom=lwhsufreebsd@gmail.com X-Spamd-Result: default: False [-3.11 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.88)[-0.878,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_TLS_LAST(0.00)[]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.03)[-0.029,0]; RCVD_IN_DNSWL_NONE(0.00)[193.219.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.19)[ipnet: 209.85.128.0/17(-3.45), asn: 15169(-2.45), country: US(-0.06)]; FORGED_SENDER(0.30)[lwhsu@freebsd.org,lwhsufreebsd@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[193.219.85.209.rep.mailspike.net : 127.0.0.17]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[lwhsu@freebsd.org,lwhsufreebsd@gmail.com]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jul 2019 17:36:45 -0000 On Wed, Jul 17, 2019 at 1:29 AM Andriy Gapon wrote: > > On 16/07/2019 18:52, Andriy Gapon wrote: > > Author: avg > > Date: Tue Jul 16 15:52:47 2019 > > New Revision: 350044 > > URL: https://svnweb.freebsd.org/changeset/base/350044 > > > > Log: > > MFC r349460: gpiobus: provide a new hint, pin_list > > > > "pin_list" allows to specify child pins as a list of pin numbers. > > Existing hint "pins" serves the same purpose but with a 32-bit wide bit > > mask. One problem with that is that a controller can have more than 32 > > pins. One example is amdgpio. Also, a list of numbers is a little bit > > more human friendly than a matching bit mask. As a side note, it seems > > that in FDT pins are typically specified by their numbers as well. > > > > This commit also adds accessors for instance variables (IVARs) that > > define the child pins. My primary goal is to allow a child to be > > configured programmatically rather than via hints (assuming that FDT is > > not supported on a platform). Also, while a child should not care about > > specific pin numbers that are allocated to it, it could be interested in > > how many were actually assigned to it. > > > > While there, I removed "flags" instance variable. It was unused. > > This change (the "flags" removal, specifically) broke build on OFW > platforms (powerpc). > I am working on a fix, it should be trivial. I've merged r349472 and it should be fine now. Best, Li-Wen