From owner-freebsd-current Fri Dec 25 19:00:44 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id TAA25623 for freebsd-current-outgoing; Fri, 25 Dec 1998 19:00:44 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from janus.syracuse.net (janus.syracuse.net [205.232.47.15]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id TAA25617 for ; Fri, 25 Dec 1998 19:00:42 -0800 (PST) (envelope-from green@unixhelp.org) Received: from localhost (green@localhost) by janus.syracuse.net (8.8.8/8.8.7) with ESMTP id WAA24454; Fri, 25 Dec 1998 22:00:24 -0500 (EST) Date: Fri, 25 Dec 1998 22:00:24 -0500 (EST) From: Brian Feldman X-Sender: green@janus.syracuse.net To: Bruce Evans cc: current@FreeBSD.ORG Subject: Re: revoke of fifos In-Reply-To: <199812251047.VAA29549@godzilla.zeta.org.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, 25 Dec 1998, Bruce Evans wrote: > >revoke(2) on VFIFO types is broken now, leading to stranded mbuf's. I suppose > > I don't think it has ever worked in BSD. Nor should it need to since, according to revoke.2: Access to a file may be revoked only by its owner or the super user. The revoke() function is currently supported only for block and character special device files. > > >bde is tracking this down, but for now, why don't we return EINVAL in revoke(2)? > > I thought it wasn't urgent because I thought that only root could revoke :-(. Nope. Also, to keep in accordance with the manpage, look at the code in -STABLE, which actually seems to be correct: vp = nd.ni_vp; if (vp->v_type != VCHR && vp->v_type != VBLK) { error = EINVAL; goto out; } error = VOP_GETATTR(vp, &vattr, p->p_ucred, p); > > Bruce > Brian Feldman _ __ ___ ___ ___ green@unixhelp.org _ __ ___ | _ ) __| \ http://www.freebsd.org/ _ __ ___ ____ | _ \__ \ |) | FreeBSD: The Power to Serve! _ __ ___ ____ _____ |___/___/___/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message