From owner-freebsd-ports@FreeBSD.ORG Fri Jun 20 01:54:06 2008 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3ECE71065679 for ; Fri, 20 Jun 2008 01:54:06 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.155]) by mx1.freebsd.org (Postfix) with ESMTP id AC25E8FC1C for ; Fri, 20 Jun 2008 01:54:05 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: by fg-out-1718.google.com with SMTP id l26so603626fgb.35 for ; Thu, 19 Jun 2008 18:54:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=zXTia+t3aEYkD38Sfy21VOvCGhgNm4E8HFq/GKPxJuU=; b=MKf4S6RKjvzjxgPHUXp83igfs07z4CvLhXFJ6nY/qafoGQjFQiUDxDhPbwc/rxZCUd WEdbPSwnkFaZGDOT4fNOZi0vpKA1TtDAhjtQC5CqOeHcm43d+IJ7n8g5PpZDtX2FoMkI fFXLZvcdb+lHKjgCTcjIF1HvZ9bpz1ZZMftWs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=E9eRXCIrFoMYwgrF+EsE9nwZT24cUIskqZLybIaXuPpJhvXtwoxQFXbO/nXdpu23gm csmfmeg20NYfr20UK+87Ttc55EmFALwTfKdycXodZ+rqt404zXJ5VL6VIc2i55TE6DdH hUex2rl3oAXUiPmihoZxAme/OassDEdQ7jAU8= Received: by 10.86.60.14 with SMTP id i14mr3067492fga.75.1213926844442; Thu, 19 Jun 2008 18:54:04 -0700 (PDT) Received: by 10.86.51.1 with HTTP; Thu, 19 Jun 2008 18:54:04 -0700 (PDT) Message-ID: <7d6fde3d0806191854o461d3bddxa44d011e56c4b73b@mail.gmail.com> Date: Thu, 19 Jun 2008 18:54:04 -0700 From: "Garrett Cooper" To: "Kris Kennaway" In-Reply-To: <485B0A6C.3080301@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <676047.76296.qm@web32706.mail.mud.yahoo.com> <20080619163501.GB12160@atarininja.org> <485A921C.80602@FreeBSD.org> <20080619210519.GV18873@graf.pompo.net> <485B0A6C.3080301@FreeBSD.org> Cc: freebsd-ports@freebsd.org Subject: Re: regression-test X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jun 2008 01:54:06 -0000 On Thu, Jun 19, 2008 at 6:39 PM, Kris Kennaway wrote: > Thierry Thomas wrote: >> >> Le Jeu 19 jui 08 =E0 19:06:36 +0200, Kris Kennaway >> =E9crivait : >> >>> We *want* regression tests to be available unconditionally -- that is w= hy >>> I added the hook to the package build process to run them if present. >>> Please don't hack around this because you think you're doing us a favo= ur >>> :-) >> >> I try to enable regression-test when possible, but the current >> implementation is a post-build target, and some ports' testings need a >> post-install target. In these cases, I enclose the regression-test >> target between .ifdef MAINTAINER_MODE. > > I'd say those ports are broken; conceptually, you should be testing wheth= er > or not your port works *before* you install it, not after. > > Kris Agreed. Functionality verification is a requirement for acceptance in any release structure, not the other way around. -Garrett