From owner-svn-src-head@freebsd.org  Tue Aug  9 06:00:04 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E041ABB365D;
 Tue,  9 Aug 2016 06:00:04 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id A67841877;
 Tue,  9 Aug 2016 06:00:03 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id JAA06752;
 Tue, 09 Aug 2016 09:00:01 +0300 (EEST)
 (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1bX053-0005fx-GH; Tue, 09 Aug 2016 09:00:01 +0300
Subject: Re: svn commit: r303763 - in head/sys/cddl: compat/opensolaris/sys
 contrib/opensolaris/uts/common/fs/zfs
 contrib/opensolaris/uts/common/fs/zfs/sys
To: Navdeep Parhar <np@FreeBSD.org>, src-committers@FreeBSD.org,
 svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org
References: <201608050623.u756N695018889@repo.freebsd.org>
 <a7fa8897-192e-9915-3bf3-d6aae6e9bfe2@FreeBSD.org>
 <1b2fa1c4-d219-7b0c-bea4-94ae325565e0@FreeBSD.org>
From: Andriy Gapon <avg@FreeBSD.org>
Message-ID: <92ce3274-916e-db48-04eb-aecd21c65aeb@FreeBSD.org>
Date: Tue, 9 Aug 2016 08:59:25 +0300
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <1b2fa1c4-d219-7b0c-bea4-94ae325565e0@FreeBSD.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Aug 2016 06:00:05 -0000

On 09/08/2016 08:10, Andriy Gapon wrote:
> On 09/08/2016 02:48, Navdeep Parhar wrote:
>> Hello Andriy,
>>
>> I'm at r303837 and have had two panics today in zfs_rename.  I have a
>> core for a kernel built with -O0.  Let me know if you think it's related
>> to this commit and need more information.  This is the stack:
>>
>> (also available at https://people.freebsd.org/~np/rename_panic.txt in
>> case the wide lines are hard to read in email).
> 
> Thank you very much for the report.
> More details are required for analysis. In frame 11 I would like to see objects
> pointed to by all arguments and additionally local variables tdzp, sdzp, zfsvfs
> and zilog.

Navdeep,

thank you for the debugging information (provided out-of-band).
The problem seems to be with leaving a variable uninitialized when a
cross-device rename is detected and then accessing that variable before checking
the error code.  Also, thank you for testing a fix.  I'll commit it very soon.

-- 
Andriy Gapon