From owner-cvs-src@FreeBSD.ORG Tue Oct 16 22:10:53 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 51B1716A417; Tue, 16 Oct 2007 22:10:53 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id C30C613C4AA; Tue, 16 Oct 2007 22:10:52 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8p) with ESMTP id 214739371-1834499 for multiple; Tue, 16 Oct 2007 18:12:17 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l9GMA8kZ095751; Tue, 16 Oct 2007 18:10:08 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Olivier Houchard Date: Tue, 16 Oct 2007 17:45:01 -0400 User-Agent: KMail/1.9.6 References: <200710161957.l9GJvaFr075367@repoman.freebsd.org> <200710161637.36950.jhb@freebsd.org> <20071016221903.GA75176@ci0.org> In-Reply-To: <20071016221903.GA75176@ci0.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200710161745.02448.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 16 Oct 2007 18:10:08 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4542/Tue Oct 16 16:31:56 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys proc.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 22:10:53 -0000 On Tuesday 16 October 2007 06:19:03 pm Olivier Houchard wrote: > On Tue, Oct 16, 2007 at 04:37:36PM -0400, John Baldwin wrote: > > On Tuesday 16 October 2007 03:57:36 pm Olivier Houchard wrote: > > > cognet 2007-10-16 19:57:36 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: (Branch: RELENG_6) > > > sys/sys proc.h > > > Log: > > > Make td_sqqueue explicitely signed, as we compare it with >= 0. On arm, > > > char defaults to unsigned. > > > > It probably should really be unsigned like td_tsqueue (serves the same > > purpose) FWIW, however it is currently an 'int' in HEAD. > > > > Probably changing td_sqqueue to u_char in HEAD, 7.x and 6.x would be the best > > fix. > > I didn't investigate much. I saw it was an int on -CURRENT, and this test : > MPASS(td->td_sqqueue < NR_SLEEPQS && td->td_sqqueue >= 0); > If td_squeue can be unsigned, the test is wrong. Yeah, it might be. It's meant to be an array index, so negative values really are meaningless. I'll fix it in HEAD if I get some time. -- John Baldwin