From owner-svn-src-all@freebsd.org Tue Sep 24 20:01:19 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DFEC112FA33; Tue, 24 Sep 2019 20:01:19 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-yb1-f194.google.com (mail-yb1-f194.google.com [209.85.219.194]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46dBsC0nnxz3R0X; Tue, 24 Sep 2019 20:01:18 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by mail-yb1-f194.google.com with SMTP id u15so161264ybm.6; Tue, 24 Sep 2019 13:01:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=6dxpSfYTP4cAvtpK5dd0ACWlVadmnQKkbXi6YWFiLZA=; b=AR+aR7j8H7ZbFpr+eWMoZY0LN1ZkK/xk3bxxzsmZRj36rIVDZOOBcToeasGyAOBu+4 FdLljJaat6n3FAsZ7PPGZbj4EzFNBsKgZGn6672bK1/Yjr/2//rnaXXrCg25SRPO08fr yhcl1HLrOrDy4/iKvo7EHAMHFIeg9JeMGQTdre1AMj7+K7s1v01DZjymmEJh/CrtJset JR/FktfrWSyPt5BKt5fjJWGqynAbFkw0cxY/GAFBvkLxNU8DuFk9MlPdq/EEq0w8d7A6 SAeYtoBRjnCs5L85mPNJnMMQX1T+TZuVpQPM9lNONmswpOVAcn1Ra50iXBRUTPxc9z8h 7hPA== X-Gm-Message-State: APjAAAVPjGtLuBqihzYPCitRDhEYb8Ef3hSp2+C8TiiGKW9dGaA0+rhz JzAvtqLWy5ez0BuU219+EBO/wG0fJGos/cMDr08= X-Google-Smtp-Source: APXvYqxMabm2iKvDdrXoi2SPvTJ8zeXr1VA48sj739io9bLIG7lnI7mDllW2zBVrWa5ZMzkKeC6Fja/S7zJVZUVdqAM= X-Received: by 2002:a25:af09:: with SMTP id a9mr379828ybh.405.1569355277711; Tue, 24 Sep 2019 13:01:17 -0700 (PDT) MIME-Version: 1.0 References: <201909241818.x8OIIBNr039667@repo.freebsd.org> <20190924212918.01e52920@thor.intern.walstatt.dynvpn.de> In-Reply-To: From: Li-Wen Hsu Date: Tue, 24 Sep 2019 22:01:05 +0200 Message-ID: Subject: Re: svn commit: r352657 - in head/sys: conf kern modules/tcp modules/tcp/bbr netinet netinet/tcp_stacks sys To: Randall Stewart Cc: "O. Hartmann" , Randall Ray Stewart , src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 46dBsC0nnxz3R0X X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of lwhsufreebsd@gmail.com designates 209.85.219.194 as permitted sender) smtp.mailfrom=lwhsufreebsd@gmail.com X-Spamd-Result: default: False [-3.11 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_NEQ_ENVFROM(0.00)[lwhsu@freebsd.org,lwhsufreebsd@gmail.com]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; RCVD_TLS_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[194.219.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.11)[ipnet: 209.85.128.0/17(-3.30), asn: 15169(-2.19), country: US(-0.05)]; FORGED_SENDER(0.30)[lwhsu@freebsd.org,lwhsufreebsd@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[194.219.85.209.rep.mailspike.net : 127.0.0.17]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Sep 2019 20:01:19 -0000 I mean the head (r352657) world and GENERIC kernel can be built successfully on 12.0-R, which is we guaranteed. Also the LINT kernel build is fine on CI: https://ci.freebsd.org/job/FreeBSD-head-amd64-LINT/13781/ So I was curious about the build environment of that build failure. Best, Li-Wen On Tue, Sep 24, 2019 at 9:55 PM Randall Stewart wrote: > > 12.0R would not have BBR .. its only in head=E2=80=A6 hmm it could be a i= ssue with TCP_RATELIMIT not defined > though I did compile GENERIC without the extra stacks (and without rate l= imit and hpts) and that > compiled ok.. > > R > > > On Sep 24, 2019, at 12:49 PM, Li-Wen Hsu wrote: > > > > On Tue, Sep 24, 2019 at 9:29 PM O. Hartmann wr= ote: > >> > >> -----BEGIN PGP SIGNED MESSAGE----- > >> Hash: SHA256 > >> > >> Am Tue, 24 Sep 2019 18:18:11 +0000 (UTC) > >> Randall Stewart schrieb: > >> > >>> Author: rrs > >>> Date: Tue Sep 24 18:18:11 2019 > >>> New Revision: 352657 > >>> URL: https://svnweb.freebsd.org/changeset/base/352657 > > > > ... > > > >> This break kernel builds: > >> > >> [...] > >> /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/bbr.c:5613:9:= error: implicit > >> declaration of function 'tcp_chg_pacing_rate' is invalid in C99 > >> [-Werror,-Wimplicit-function-declaration] nrte =3D tcp_chg_pacing_rate= (bbr->r_ctl.crte, ^ > >> /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/bbr.c:5613:9:= error: this function > >> declaration is not a prototype [-Werror,-Wstrict-prototypes] > >> /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/bbr.c:5613:7:= error: incompatible > >> integer to pointer conversion assigning to 'const struct tcp_hwrate_li= mit_table *' from 'int' > >> [-Werror,-Wint-conversion] nrte =3D tcp_chg_pacing_rate(bbr->r_ctl.crt= e, ^ > >> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ --- all_subdir_toecore --- Buildi= ng > >> /usr/obj/usr/src/amd64.amd64/sys/THOR/modules/usr/src/sys/modules/toec= ore/toecore.ko --- > >> all_subdir_tcp --- /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_s= tacks/bbr.c:10443:4: > >> error: implicit declaration of function 'tcp_rel_pacing_rate' is inval= id in C99 > >> [-Werror,-Wimplicit-function-declaration] tcp_rel_pacing_rate(bbr->r_c= tl.crte, bbr->rc_tp); ^ > >> - --- all_subdir_tpm --- > >> =3D=3D=3D> tpm (all) > >> - --- all_subdir_tcp --- > >> /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/bbr.c:10443:4= : error: this function > >> declaration is not a prototype [-Werror,-Wstrict-prototypes] --- all_s= ubdir_trm --- > >> =3D=3D=3D> trm (all) > >> - --- all_subdir_tcp --- > >> /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/bbr.c:14307:2= 1: error: implicit > >> declaration of function 'tcp_set_pacing_rate' is invalid in C99 > >> [-Werror,-Wimplicit-function-declaration] bbr->r_ctl.crte =3D tcp_set_= pacing_rate(bbr->rc_tp, > > > > CI completed a clean build on 12.0-R: > > https://ci.freebsd.org/job/FreeBSD-head-amd64-build/14672/ > > > > What's your build environment and platform? > > > > Best, > > Li-Wen > > ------ > Randall Stewart > rrs@netflix.com > > >