From owner-freebsd-stable@FreeBSD.ORG Thu Oct 16 07:17:03 2008 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BC64E10656A5 for ; Thu, 16 Oct 2008 07:17:03 +0000 (UTC) (envelope-from jdc@koitsu.dyndns.org) Received: from QMTA04.westchester.pa.mail.comcast.net (qmta04.westchester.pa.mail.comcast.net [76.96.62.40]) by mx1.freebsd.org (Postfix) with ESMTP id 651F58FC54 for ; Thu, 16 Oct 2008 07:17:02 +0000 (UTC) (envelope-from jdc@koitsu.dyndns.org) Received: from OMTA04.westchester.pa.mail.comcast.net ([76.96.62.35]) by QMTA04.westchester.pa.mail.comcast.net with comcast id TKGZ1a0090ldTLk54KH25x; Thu, 16 Oct 2008 07:17:02 +0000 Received: from koitsu.dyndns.org ([69.181.141.110]) by OMTA04.westchester.pa.mail.comcast.net with comcast id TKH11a0052P6wsM3QKH1tP; Thu, 16 Oct 2008 07:17:02 +0000 X-Authority-Analysis: v=1.0 c=1 a=mJNHdnNIt1IA:10 a=6I5d2MoRAAAA:8 a=FP58Ms26AAAA:8 a=QycZ5dHgAAAA:8 a=xyICPfz3WQGLBWeIYbwA:9 a=hIhv6WGBB2CQDR-BSxsA:7 a=Ry75OVrOEhPMq1Ur9zpXNWfeJAQA:4 a=EoioJ0NPDVgA:10 a=LY0hPdMaydYA:10 Received: by icarus.home.lan (Postfix, from userid 1000) id EB172C9419; Thu, 16 Oct 2008 00:17:00 -0700 (PDT) Date: Thu, 16 Oct 2008 00:17:00 -0700 From: Jeremy Chadwick To: "Andrey V. Elsukov" Message-ID: <20081016071700.GA2793@icarus.home.lan> References: <676151223134689@webmail38.yandex.ru> <20081005004808.GA70137@icarus.home.lan> <48E99C18.6070602@yandex.ru> <20081006051211.GA10542@icarus.home.lan> <20081010115855.GA31707@icarus.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081010115855.GA31707@icarus.home.lan> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: freebsd-stable@freebsd.org, kib@freebsd.org, sos@freebsd.org Subject: Re: Request for testing: ata(4) MFC X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Oct 2008 07:17:03 -0000 On Fri, Oct 10, 2008 at 04:58:55AM -0700, Jeremy Chadwick wrote: > On Sun, Oct 05, 2008 at 10:12:11PM -0700, Jeremy Chadwick wrote: > > On Mon, Oct 06, 2008 at 09:03:20AM +0400, Andrey V. Elsukov wrote: > > > Jeremy Chadwick wrote: > > >> Also, does your patch include any fixes (intentional or inadvertent) for > > >> Intel MatrixRAID? This has been a sore spot for FreeBSD for quite > > >> some time, and I'm curious to know if that has been fixed. > > > > > > There is only one fix for Intel Matrix RAID: > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/121899 > > > > Ahh, yeah, I've seen that one as well. I'll apply the patch and let you > > know if the behaviour documented in the PR happens. > > I'm sorry I haven't gotten around to testing this -- my day (night) job > has kept me incredibly busy, and I've had hardly any time at home to > work on personal projects. It sucks. > > I'll try to make time for testing either today or tomorrow. I finally got around to testing this patch tonight on my P4SCE box. Said box does not use AHCI. Based on skimming the code, the patch needs to be tested on the following: - Systems with AHCI - Systems using SATA port multipliers - Systems using Silicon Image chips - Systems using VIA chipsets with SATA devices attached - Systems with Promise controllers that have ATAPI devices attached - Systems using Adaptec 1420SA controllers - Systems using ITE ATA/IDE controllers, specifically ITE 8213F - Systems that use suspend/resume Right now I have access to an AHCI-based system, but I do not feel comfortable testing yanking of disks or pulling of SATA cables to simulate a drive/controller failure -- because the disks attached to said box contain sensitive/important data. That said, this needs to be thoroughly tested: - Disk and/or controller failures when AHCI is in use (specifically due to major changes in ata_ahci_reset() and ata_ahci_softreset()) Other items: - Could someone provide an explanation of the 48-bit LBA addressing changes (see lines 988-1003 in the patch)? I'd like to know what they do, and if further QA/testing is needed with this. - Can we please see about adding the FreeNAS project's ata timeout sysctls? I see lots of delays/sleeps in numerous pieces of code that pertain to soft or hard resets of AHCI controllers, and I often worry about the implications of hard-coded timeouts. http://freenas.svn.sourceforge.net/viewvc/freenas/trunk/build/kernel-patches/ata/files/patch-ata.diff?view=markup Thanks everyone! -- | Jeremy Chadwick jdc at parodius.com | | Parodius Networking http://www.parodius.com/ | | UNIX Systems Administrator Mountain View, CA, USA | | Making life hard for others since 1977. PGP: 4BD6C0CB |