From owner-freebsd-bugs@FreeBSD.ORG  Mon Sep 13 06:27:39 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 887FA16A4CF; Mon, 13 Sep 2004 06:27:39 +0000 (GMT)
Received: from prg.traveller.cz (prg.traveller.cz [193.85.2.77])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8AA1643D5C; Mon, 13 Sep 2004 06:27:36 +0000 (GMT)
	(envelope-from dan@obluda.cz)
Received: from [10.11.0.2] (kulesh.obluda.cz [193.179.22.243])
	by prg.traveller.cz (8.12.10/8.12.10/prg) with ESMTP id i8D6RWp5014473
	(version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO);
	Mon, 13 Sep 2004 08:27:34 +0200 (CEST)
Message-ID: <41453DD2.7030009@obluda.cz>
Date: Mon, 13 Sep 2004 08:27:30 +0200
From: Dan Lukes <dan@obluda.cz>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
	rv:1.8a3) Gecko/20040817
X-Accept-Language: cs, sk, en
MIME-Version: 1.0
To: Giorgos Keramidas <keramida@freebsd.org>
References: <200409120237.i8C2bb7V007096@kulesh.obluda.cz>
	<20040912183535.GE1047@gothmog.gr> <20040913033216.K77141@ns.obluda.cz>
	<20040913053313.GA31577@gothmog.gr>
In-Reply-To: <20040913053313.GA31577@gothmog.gr>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
cc: freebsd-bugs@freebsd.org
Subject: Re: bin/71618: [PATCH] cleanup of the usr.sbin/timed code
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Sep 2004 06:27:39 -0000

Giorgos Keramidas wrote:
>>	I'm compiling with -Wall -O3.

> AFAIK -O3 is a bit unsafe in FreeBSD.  I know that some warnings don't
> work correctly in GCC though, so `-O -Wall' shoule be fine most of the

	I didn't run the kernel nor world compiled with O3. I use it only
during this code inspection as O3 allow the compiler to reveal some
suspicious constructs.

> WARNS=1 includes -Wall, so you're fine with just WARNS=1.  Higher levels
> of WARNS enable other sorts of warnings too.  The file bsd.sys.mk in

>     CFLAGS="-Wall -Wno-format-y2k -Wreturn-type -Wcast-qual \
> 	-Wwrite-strings -Wswitch -Wshadow -Wcast-align"

	I miss it. I will check it during next turn ...

Bye
Dan