Date: Mon, 13 Sep 2004 08:27:30 +0200 From: Dan Lukes <dan@obluda.cz> To: Giorgos Keramidas <keramida@freebsd.org> Cc: freebsd-bugs@freebsd.org Subject: Re: bin/71618: [PATCH] cleanup of the usr.sbin/timed code Message-ID: <41453DD2.7030009@obluda.cz> In-Reply-To: <20040913053313.GA31577@gothmog.gr> References: <200409120237.i8C2bb7V007096@kulesh.obluda.cz> <20040912183535.GE1047@gothmog.gr> <20040913033216.K77141@ns.obluda.cz> <20040913053313.GA31577@gothmog.gr>
next in thread | previous in thread | raw e-mail | index | archive | help
Giorgos Keramidas wrote: >> I'm compiling with -Wall -O3. > AFAIK -O3 is a bit unsafe in FreeBSD. I know that some warnings don't > work correctly in GCC though, so `-O -Wall' shoule be fine most of the I didn't run the kernel nor world compiled with O3. I use it only during this code inspection as O3 allow the compiler to reveal some suspicious constructs. > WARNS=1 includes -Wall, so you're fine with just WARNS=1. Higher levels > of WARNS enable other sorts of warnings too. The file bsd.sys.mk in > CFLAGS="-Wall -Wno-format-y2k -Wreturn-type -Wcast-qual \ > -Wwrite-strings -Wswitch -Wshadow -Wcast-align" I miss it. I will check it during next turn ... Bye Dan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41453DD2.7030009>