From owner-svn-src-all@freebsd.org Tue Dec 15 19:39:38 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BA9CF4C0202; Tue, 15 Dec 2020 19:39:38 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CwT9Q4dxcz4m6l; Tue, 15 Dec 2020 19:39:38 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1608061178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FjLNjF3jwoT9gb5N/U3zA7vTiKojInAE8fOU8Nn68W4=; b=Mp6ZhJ6qUK0ktrb0g86m4r3HoJhEvS7VwCrPtp2m1QEHRn5FOhei3lZaPcjO0Y9jvOADZ4 PN5J0pFQFAQnj+xshDCJXKeL95Cpwg0y5zO/nXyQdy+6EKQ9KCj+RHj0Xkl29O5tGuimU7 MwMLzxJAIdWByQclTdI2iUu29nvHRUtcdyRNVZTapBFbVbKarmcYBMlf68MowStJnfZe/n Pl/QEAXw9GIZGLtaZNJNsm7ICoSTyXZBOwHjWOfHN8hgCz/ttPl83We0z0gHI/SBqC8Cnm 9r5RG9pVvBbJ3qxuXECjg/jUg3oPRq1oaD7r4fwnYejWBrMQVteridFZ1k4Mtg== Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 702D216C85; Tue, 15 Dec 2020 19:39:38 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 6FF6A524F; Tue, 15 Dec 2020 19:39:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id bsmDAbXebrRn; Tue, 15 Dec 2020 19:39:34 +0000 (UTC) Subject: Re: svn commit: r368523 - head/sys/vm DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com AD25A5246 To: Mark Johnston , Hans Petter Selasky Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202012102044.0BAKiTHh011767@repo.freebsd.org> From: Bryan Drewery Organization: FreeBSD Message-ID: Date: Tue, 15 Dec 2020 11:39:34 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gnRroaiJmggqThfUt1wReLq4WxTTUkNY3" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1608061178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FjLNjF3jwoT9gb5N/U3zA7vTiKojInAE8fOU8Nn68W4=; b=ivaTaj4K7Dmq7eFCmZ02wVNXVQv3ztxy9Ox0N3xgS82YrS8tWw0vbqLnIPu9dCPIiOETCW lxUEywcxZOjz4wWvoCWzLXgnkBIEIPBzTF3SN1leZUUoMbj6LmJihqxBB/Pvz9SDvyUGal iRVYq5ZGPYEdjqTnXYEoPUbinFvQgBmC44VoTxSFPTZBbifxXvV5J8M/fEn1WuXXbFW4ZO r0ARCwYk3D3lTFOYeQny1dX7ok5/hHahRAHeXMlBUPQU0gdou+O+DfXB7MMzawvjQxmd5x MNaefGOC94PMk9IzdGWw4ydv21/8n1fZwyLT5USvdUqxoBNs2GRtvTOwM67frw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1608061178; a=rsa-sha256; cv=none; b=Kq3sWKZNyahSRrqbLJ4atZJEdjm/Q3uM5q/IGK+oiXTLUFDwfm5cRXfD7LBggoR5J1LuBF +jaRvaUBQA6+tjKXD7yxmxlehMkww2RLw8Ym+7L0Ijm+/O6llzmvYg5bY6lX4OiRSBJcJb /xODvL1O2jA1fdan6VQ3Ws1/0Vo7mQ3LNaLTj9lZ25XK0rLCVJ90W0Ti2JwC/hUaKvLi2+ bJTcTwje2poFKsvywOHw3ed5h7/3BWhSyjTItZPXU65yYjTbOrttGnBWBJXdtPOlgHwu2W jTz1Ds2aJp8XMnAeAohuUF0CI0O7V7QparBdB+gWcOlVEc9KNO+OvYRCwqkVtg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2020 19:39:38 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gnRroaiJmggqThfUt1wReLq4WxTTUkNY3 Content-Type: multipart/mixed; boundary="G8bN0TsR2GXK9oUy9Q6kXg4Wjb3qgftFo"; protected-headers="v1" From: Bryan Drewery To: Mark Johnston , Hans Petter Selasky Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: Subject: Re: svn commit: r368523 - head/sys/vm References: <202012102044.0BAKiTHh011767@repo.freebsd.org> In-Reply-To: --G8bN0TsR2GXK9oUy9Q6kXg4Wjb3qgftFo Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 12/15/2020 7:04 AM, Mark Johnston wrote: > On Tue, Dec 15, 2020 at 03:33:09PM +0100, Hans Petter Selasky wrote: >> On 12/15/20 3:27 PM, Mark Johnston wrote: >>>> I'm seeing the following panic: >>>> >>>> panic("vm_wait in early boot") >>>> vm_wait_domain() >>>> kmem_alloc_contig_pages() >>>> kmem_alloc_contig_domainset() >>>> kmem_alloc_contig() >>>> contigmalloc() >>>> x86bios_alloc() >>>> vesa_configure() >>>> vesa_mod_event() >>>> vesa_module_register_init() >>>> mi_startup() >>> Is it on a NUMA system? I see that the new logic won't work properly= if >>> there are empty domains, so this suggests that we really do need a >>> special contig iterator as discussed in the review. >> >> Yes, this is a numa system. >> >> I just noticed, that before r368523 "flags" was updated by=20 >> _vm_domainset_iter_policy_init() to always contain M_NOWAIT and that=20 >> avoids the wait logic, but I think x86bios_alloc() doesn't get its=20 >> memory then. >=20 > Yes, but note that vm_domainset_iter_policy() will also call > vm_wait_doms() if a M_NOWAIT allocation from each domain fails. > x86bios_alloc() requests memory from the first 1MB of physical memory, > but because contigmalloc() uses a round-robin iterator initialized from= > per-thread state it may try from the "wrong" domain first. So really a= > different solution to the original problem is needed. >=20 >> I'm not sure if x86bios_alloc() needs to be attached a bit later anywa= y? >> >> --HPS I have reverted the change in r368673 until we come up with a more comprehensive fix. --=20 Regards, Bryan Drewery --G8bN0TsR2GXK9oUy9Q6kXg4Wjb3qgftFo-- --gnRroaiJmggqThfUt1wReLq4WxTTUkNY3 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEE+Rc8ssOq6npcih8JNddxu25Gl88FAl/ZEPYFAwAAAAAACgkQNddxu25Gl899 gggA0dD7mNfQlb3+ZZ4PKtn2Vt+H1gPQaXG6ZQDQgjnopUOiFDJVKSZhs93RZM4n3B7zcjLn4aND IcETuRAy/kmktwTgJfQRyWxyqOodI8KDEmyltBTg90GIqspF7bHwaamHMa63iQwwJ4Yerm03jOC2 gLlAhQ7wN1PzDZJoaS5rWt0STCSKoH7qoGAnUv2eoJl2N7vv4tNZej5Q1p06rFCqjZEN5WNNMT6H ei0q9H4lW9KNLznHlHWOj7KY2sIzYVCBjMU/L6E8FdVuwHeLvlzREfeRypVNBIbJRkA5zzZ4cfnB Aycs4oZcLsAN0cxIrRXrY4S6yR/wGJ/070K5IqTxYg== =pxKg -----END PGP SIGNATURE----- --gnRroaiJmggqThfUt1wReLq4WxTTUkNY3--