From owner-svn-ports-all@freebsd.org Mon Nov 6 15:49:11 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 667EBE61698; Mon, 6 Nov 2017 15:49:11 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46D5374897; Mon, 6 Nov 2017 15:49:11 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 777D01315C; Mon, 6 Nov 2017 15:49:10 +0000 (UTC) Date: Mon, 6 Nov 2017 15:49:10 +0000 From: Alexey Dokuchaev To: "Tobias C. Berner" Cc: Baptiste Daroussin , Jochen Neumeister , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r453522 - head/www/tikiwiki Message-ID: <20171106154910.GA80443@FreeBSD.org> References: <201711050811.vA58BimG043763@repo.freebsd.org> <20171105111520.mwcfak3lp2peecpx@ivaldir.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Nov 2017 15:49:11 -0000 On Sun, Nov 05, 2017 at 12:47:13PM +0100, Tobias C. Berner wrote: > To quote mat@ from > https://lists.freebsd.org/pipermail/svn-ports-all/2017-August/159181.html > > It is explained in the porter's handbook, always use DISTVERSION except > > when there is no version in the distribution file, or when DISTVERSION > > gives an incorrect PORTVERSION. I've seen the quote, but I don't see anything wrong with using PORTVERSION (like we traditionally did) when it is "simple" (that is, identical to the DISTVERSION). It might look "cleaner" in mat@'s eyes to always use (set) DISTVERSION since it is, in fact, closely tied to the *distfile* version, but enforcing this just based on that is a bit too much. Personally I'd prefer that PHB text laxed (and keep using PORTVERSION when it suffices). ./danfe