From owner-freebsd-hackers@FreeBSD.ORG  Sun Jun 15 07:23:43 2003
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9020737B401
	for <freebsd-hackers@FreeBSD.org>;
	Sun, 15 Jun 2003 07:23:43 -0700 (PDT)
Received: from nd250009.gab.xdsl.ne.jp (nd250009.gab.xdsl.ne.jp
	[61.202.250.9])	by mx1.FreeBSD.org (Postfix) with ESMTP id B6A8D43F85
	for <freebsd-hackers@FreeBSD.org>;
	Sun, 15 Jun 2003 07:23:42 -0700 (PDT)
	(envelope-from nork@FreeBSD.org)
Received: from nd250009.gab.xdsl.ne.jp (nadesico.ninth-nine.com
	[192.168.36.3]) by nd250009.gab.xdsl.ne.jp (8.12.9/8.12.9/NinthNine) with SMTP
	id h5FENf1I056184; Sun, 15 Jun 2003 23:23:41 +0900 (JST) (envelope-from
	nork@FreeBSD.org)
Date: Sun, 15 Jun 2003 23:23:41 +0900 (JST)
Message-Id: <200306151423.h5FENf1I056184@nd250009.gab.xdsl.ne.jp>
From: Norikatsu Shigemura <nork@FreeBSD.org>
To: freebsd-hackers@FreeBSD.org
In-Reply-To: <20030615001154.GA1373@rot13.obsecurity.org>
References: <200306142005.h5EK5s1I017984@nd250009.gab.xdsl.ne.jp>
	<20030615001154.GA1373@rot13.obsecurity.org>
X-Mailer: Sylpheed version 0.9.2 (GTK+ 1.2.10; i386-portbld-freebsd5.1)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
cc: Kris Kennaway <kris@obsecurity.org>
Subject: Re: [SUGGEST] CPUTYPE reflects to FFLAGS in bsd.cpu.mk
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Jun 2003 14:23:43 -0000

On Sat, 14 Jun 2003 17:11:55 -0700
Kris Kennaway <kris@obsecurity.org> wrote:
> >  .if !defined(NO_CPU_CFLAGS)
> >  CFLAGS += ${_CPUCFLAGS}
> > +FFLAGS += ${_CPUCFLAGS}
> >  .endif
> The better place to do this would be in sys.mk.  See how CXXFLAGS is handled there.

	Humm.. Like following diff?
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Index: bsd.cpu.mk
===================================================================
RCS file: /home/ncvs/src/share/mk/bsd.cpu.mk,v
retrieving revision 1.28
diff -u -r1.28 bsd.cpu.mk
--- bsd.cpu.mk	22 May 2003 16:56:46 -0000	1.28
+++ bsd.cpu.mk	15 Jun 2003 14:20:03 -0000
@@ -142,9 +142,3 @@
 .if ${MACHINE_ARCH} == "alpha"
 _CPUCFLAGS += -mieee
 .endif
-
-# NB: COPTFLAGS is handled in /usr/src/sys/conf/Makefile.<arch>
-
-.if !defined(NO_CPU_CFLAGS)
-CFLAGS += ${_CPUCFLAGS}
-.endif
Index: sys.mk
===================================================================
RCS file: /home/ncvs/src/share/mk/sys.mk,v
retrieving revision 1.67
diff -u -r1.67 sys.mk
--- sys.mk	1 Jun 2003 22:13:45 -0000	1.67
+++ sys.mk	15 Jun 2003 14:21:37 -0000
@@ -40,6 +40,9 @@
 CC		?=	cc
 .endif
 CFLAGS		?=	-O -pipe
+.if !defined(NO_CPU_CFLAGS)
+CFLAGS		+=	${_CPUCFLAGS}
+.endif
 
 CXX		?=	c++
 CXXFLAGS	?=	${CFLAGS:C/-std=[a-z:0-9]+//}
@@ -64,6 +67,9 @@
 .else
 FC		?=	f77
 FFLAGS		?=	-O
+.endif
+.if !defined(NO_CPU_FFLAGS)
+FFLAGS		+=	${_CPUCFLAGS}
 .endif
 EFLAGS		?=