r TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bGtM00Jkrz3XLC; Tue, 10 Jun 2025 15:41:48 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749570108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BdZ9MvxAmUusn9E2zgw15xvmMJPgRsnAChKoykQYt74=; b=fTb5t1dDA9Xx0ss5qOgy+/+U+epfaOi7F9nxQ7Yo0UOQDIyieXCFTs08pHeH4Mlv8Kn8fM 9L1iMYDhNTJBppmWQWDBOEOwuq72DjrOPZ6NPWqERsXcisnzaTbs9bhffugUA0octrtf7E S3uDvOLzOeuC8iVZfinuO7Z7Uck+0a/xT/Jqle4BDNW/akTjVSHqDANBcrqiQeKNgwB3he 6w+6Pn8kuEBADFq8LJO7tAQjeqlRgENT5uE3ZsUEggG/yUZ7mWVIfY9TbQQKUwEi/hNbiP QkJOT581Llm8rb465Prdr5JCNMGBe3q+4gBDBSFLM6qilohVRUa9tQtp/ZeYkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749570108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BdZ9MvxAmUusn9E2zgw15xvmMJPgRsnAChKoykQYt74=; b=r6wouVWJlhkCaYKCYhRO6cyXkfDxfmzPEEMIiTYFXPGmUSyvETsZtMHeLfUGWMTkyj3aHF s2Kd94qbs17gHsK4v0alwtA7JX3bMJ5uLAr6eQHb+QCoDZCbwTk7XiPY62+phsXjl0/jmW lsz9aa2wxf7eL0njSEMStzvlSIoB9vlVsmbX1nNOUada3pS7yLj8QB1WjNtiQEirImjD4a mYqKFM6OSfHSUCGtntTS0WkbVdclWtDTnCWQyfZu/evenbLLWBKjuyey/tgzbld1y5JxQf gYlYx59cAsS3+wQQtSxaIK9+8FKQHTqBkYGxtFYX+0X/AcG6sC7usIN3/P4HCg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1749570108; a=rsa-sha256; cv=none; b=gIouEQQ7UCFgf2fLDoDHtjKn607UWcJ3kw9KUj70GqRXHoGIZi9A4ZEBURhc4gJfzAgjTq O40I7uaI4ggcA3iqN8DzLrmqi9k21c13zDcZwTa4BvBhNxoIqnBCMBdltDIu7rgxZ0jkRH CSb2uWdlyepMREeB9DunGvJ3vk89kN6p7LcAJ/OqaENnLdSaYn/Qn0SodOKHnWYFVeFs7c UgCuCRI+EMjLuj3YAzt41SA3YQl76/ncAoIkYRqnaTXkiiZWdsALSd8JgRgMUh8nMRu3mp 4iZRZOf6KOrOPsoIgz9KerKe6h/OGbKlRhPAjecxXXP3l4nI5Yf3SC48xH0ueA== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4bGtLz1fDGzH28; Tue, 10 Jun 2025 15:41:47 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Tue, 10 Jun 2025 08:41:44 -0700 From: Gleb Smirnoff To: Konstantin Belousov Cc: Rick Macklem , Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 79d0f4474653 - main - rpcbind: Ensure krpc is present. Message-ID: References: <202506091053.559ArJ8k043104@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jun 10, 2025 at 12:11:18PM +0300, Konstantin Belousov wrote: K> Apparently we already have the feature called 'warmstart', where rpcbind K> can be restarted and existing registrations are reloaded. So it is in K> fact already solved, assuming admin is careful enough to use -w. Ok, then all that needs to be done is revert this: --- a/usr.sbin/rpcbind/rpcbind.c +++ b/usr.sbin/rpcbind/rpcbind.c @@ -159,10 +159,6 @@ main(int argc, char *argv[]) update_bound_sa(); - /* Ensure krpc is loaded */ - if (modfind("krpc") < 0 && kldload("krpc") < 0) - err(1, "krpc"); - /* Check that another rpcbind isn't already running. */ if ((rpcbindlockfd = open(RPCBINDDLOCK, O_RDONLY|O_CREAT, 0444)) < 0) err(1, "%s", RPCBINDDLOCK); Without these lines, rpcbind will log: Jun 10 08:34:23 bobrik rpcbind[885]: netlink: could not create service And continue with /var/run/rpcbind.sock set up and ready to service requests from applications. We can add an extra message for verbosity: @@ -223,7 +219,10 @@ main(int argc, char *argv[]) } endnetconfig(nc_handle); - init_transport(&netlink_nconf); + if (init_transport(&netlink_nconf) != 0) { + syslog(LOG_ERR, "krpc(4) module missing? " + "Continuing without netlink/krpc transport"); + } /* * Allocate pipe fd to wake main thread from signal handler in non-racy I really don't have a strong opinion on what would be right here. I have no idea on how wide is the use of rpcbind w/o NFS. Kostik, Rick and Dag-Erling, may you together come to agreement on what is right here? -- Gleb Smirnoff