From owner-svn-ports-head@FreeBSD.ORG  Sun Aug 17 19:41:12 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 928F9125;
 Sun, 17 Aug 2014 19:41:12 +0000 (UTC)
Received: from mail-yh0-x232.google.com (mail-yh0-x232.google.com
 [IPv6:2607:f8b0:4002:c01::232])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 28C8927A4;
 Sun, 17 Aug 2014 19:41:12 +0000 (UTC)
Received: by mail-yh0-f50.google.com with SMTP id v1so3820246yhn.23
 for <multiple recipients>; Sun, 17 Aug 2014 12:41:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=rUk9Dah2Ie0f71vBgsKsBsv/tRfT5QQ+6RNGtR99jyM=;
 b=uh2r+sylGav5rOWr5QFGSX0RFXbPE50+oZxnH3PPA5Qiej/2T8CywuxdzmlhqYLttu
 gbmC2dtFZFtbe47hOjqnPePpaeoLROYWr7oVSY7iHK4hk1Jk11QIZ5tBX6cTtHMgpkSP
 BoD9OnbsrnkXSPy2Mk7toV/I1V1tStCC+ZxTvyHs4t60JTOZ0H6ygy3bPZmD31NJ12jk
 t2vULGyG0kjXsRupwElKCY6EYJ+FDAYERZhaDjjVF//E8dHMWLI9hFVErYLjLMspMWNx
 2FWg30ryUKHwa5unUTLuwffYwZ7P9pGr8IECIEfSTy9tPd3uoD/oN3sI1qFITvGGdtgO
 JYJQ==
MIME-Version: 1.0
X-Received: by 10.236.83.129 with SMTP id q1mr3550656yhe.124.1408304471325;
 Sun, 17 Aug 2014 12:41:11 -0700 (PDT)
Sender: antoine.brodin.freebsd@gmail.com
Received: by 10.170.164.197 with HTTP; Sun, 17 Aug 2014 12:41:11 -0700 (PDT)
In-Reply-To: <20140817193838.GO42528@f10.opsec.eu>
References: <201408171932.s7HJWIkV088586@svn.freebsd.org>
 <CAALwa8mFdvSQRPgPVntA4x+QMH2ceVOWQXB1KZiGHQEGA4M9gw@mail.gmail.com>
 <20140817193838.GO42528@f10.opsec.eu>
Date: Sun, 17 Aug 2014 21:41:11 +0200
X-Google-Sender-Auth: aCzwTu8PeCpb-AMhUmIvIgESAss
Message-ID: <CAALwa8n_GQse+Qt41Yxeu=+LV7J=UZizBsHn5GLoRWVtBi=y6A@mail.gmail.com>
Subject: Re: svn commit: r365227 - head/Mk/Uses
From: Antoine Brodin <antoine@FreeBSD.org>
To: Kurt Jaeger <pi@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Aug 2014 19:41:12 -0000

On Sun, Aug 17, 2014 at 9:38 PM, Kurt Jaeger <pi@freebsd.org> wrote:
> Hi!
>
>> > Log:
>> >   Mk/Uses/perl5.mk: Fix logic for removal of empty .bs files
> [...]
>
>> >  # Starting with perl 5.20, the empty bootstrap files are not installed any
>> >  # more.  As we don't need them anyway, remove it altogether.
>> > -.if ${PERL_LEVEL} < 502000
>> > +.if ${PERL_LEVEL} >= 502000
>> >  fix-perl-bs:
>> >         -@${FIND} ${STAGEDIR} -name '*.bs' -size 0 -delete
>> >  .endif
>>
>>
>> This is totally wrong, please revert.
>
> I had the case with devel/p5-File-Map that it still installs a
> .bs in the STAGEDIR. So I searched on how to fix it and found this
> please in Mk/Uses/perl5.mk and thought:
>
> Isn't the logic the wrong way around ?
>
> Please explain the logic behind the fix-perl-bs for ${PERL_LEVEL} >= 502000 ?

The logic is that with perl 5.20,  you don't need to remove the .bs files.

Cheers,

Antoine