From owner-freebsd-current@FreeBSD.ORG  Fri Dec 11 15:22:18 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7B99B1065672;
	Fri, 11 Dec 2009 15:22:18 +0000 (UTC)
	(envelope-from gjb@semihalf.com)
Received: from smtp.semihalf.com (smtp.semihalf.com [213.17.239.109])
	by mx1.freebsd.org (Postfix) with ESMTP id 2D6BE8FC0C;
	Fri, 11 Dec 2009 15:22:17 +0000 (UTC)
Received: from localhost (unknown [213.17.239.109])
	by smtp.semihalf.com (Postfix) with ESMTP id BE3CBC3BA7;
	Fri, 11 Dec 2009 16:22:09 +0100 (CET)
X-Virus-Scanned: by amavisd-new at semihalf.com
Received: from smtp.semihalf.com ([213.17.239.109])
	by localhost (smtp.semihalf.com [213.17.239.109]) (amavisd-new,
	port 10024)
	with ESMTP id 6LoyiSEFC09N; Fri, 11 Dec 2009 16:22:09 +0100 (CET)
Received: from [192.168.1.12] (aamd191.neoplus.adsl.tpnet.pl [83.5.59.191])
	by smtp.semihalf.com (Postfix) with ESMTPA id A89E6C3BA4;
	Fri, 11 Dec 2009 16:22:08 +0100 (CET)
Message-ID: <4B226379.80605@semihalf.com>
Date: Fri, 11 Dec 2009 16:21:29 +0100
From: Grzegorz Bernacki <gjb@semihalf.com>
User-Agent: Thunderbird 2.0.0.16 (X11/20090618)
MIME-Version: 1.0
To: Andriy Gapon <avg@icyb.net.ua>
References: <4B2252BE.8080806@semihalf.com> <4B225F05.20004@icyb.net.ua>
In-Reply-To: <4B225F05.20004@icyb.net.ua>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Mailman-Approved-At: Fri, 11 Dec 2009 16:52:13 +0000
Cc: Alexander Motin <mav@freebsd.org>, freebsd-current@freebsd.org
Subject: Re: Possible bug in ata-disk.c
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Dec 2009 15:22:18 -0000

Andriy Gapon wrote:
> on 11/12/2009 16:10 Grzegorz Bernacki said the following:
>> Hi,
>>
>> I've looked over ATA code and I've noticed that setting
>> DISKFLAG_CANDELETE big in disk->d_flags clears DISKFLAGS_CANFLUSHCAHCE
>> bit if it was set. Below is the patch.
...
> 
> It seems that you are correct.
> The only confusing thing is that you supplied a reverse diff :)
> 

Yes, you're right, sorry for that.

Grzesiek