From owner-cvs-all Fri Jul 30 11:49:28 1999 Delivered-To: cvs-all@freebsd.org Received: from dingo.cdrom.com (dingo.cdrom.com [204.216.28.145]) by hub.freebsd.org (Postfix) with ESMTP id 54C7815154; Fri, 30 Jul 1999 11:49:26 -0700 (PDT) (envelope-from mike@dingo.cdrom.com) Received: from dingo.cdrom.com (localhost.cdrom.com [127.0.0.1]) by dingo.cdrom.com (8.9.3/8.8.8) with ESMTP id LAA00424; Fri, 30 Jul 1999 11:43:41 -0700 (PDT) (envelope-from mike@dingo.cdrom.com) Message-Id: <199907301843.LAA00424@dingo.cdrom.com> X-Mailer: exmh version 2.0.2 2/24/98 To: Warner Losh Cc: Mike Smith , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/apm apm.c In-reply-to: Your message of "Fri, 30 Jul 1999 12:40:27 MDT." <199907301840.MAA83037@harmony.village.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 30 Jul 1999 11:43:41 -0700 From: Mike Smith Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk > In message <199907301615.JAA55743@freefall.freebsd.org> Mike Smith writes: > : Erk, more APMIO_BIOS stuff I missed. Temporarily disable the resume timer > : support until I can implement it as an ioctl proper. > > Why are you removing the APMIO_BIOS stuff? It was put in there > specifically so that new functionality in the apm program without > needing to change kernels. It was also put in so that OEM specific > BIOS calls could be made, which the kernel cannot know about. It's removed just now simply because the old implementation couldn't work. I didn't actually think it was being used at all or I would have engineered something cleaner. I'm not entirely sure yet about the ramifications of user-space code being able to call the BIOS; there are security and locking implications that I want to consider, and a good case for a more generalised interface. APM should also become a module (real soon now), which will take the pressure off on any "vendor specific" features as well; so far we don't actually support anything "vendor specific" anyway, so it's a bit of a furphy right now. > I'm sorry that I haven't said anything before, but it just clicked > what you were removing. It's just WIP, and your point's well taken. -- \\ The mind's the standard \\ Mike Smith \\ of the man. \\ msmith@freebsd.org \\ -- Joseph Merrick \\ msmith@cdrom.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message