From owner-cvs-usrbin  Sun Jul 23 21:42:34 1995
Return-Path: cvs-usrbin-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.11/8.6.6) id VAA00602
          for cvs-usrbin-outgoing; Sun, 23 Jul 1995 21:42:34 -0700
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.34])
          by freefall.cdrom.com (8.6.11/8.6.6) with ESMTP id VAA00589
          ; Sun, 23 Jul 1995 21:42:15 -0700
Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id OAA01596; Mon, 24 Jul 1995 14:39:42 +1000
Date: Mon, 24 Jul 1995 14:39:42 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199507240439.OAA01596@godzilla.zeta.org.au>
To: bde@zeta.org.au, rgrimes@gndrsh.aac.dev.com
Subject: Re: cvs commit: src/usr.bin/chflags Makefile
Cc: CVS-commiters@freefall.cdrom.com, cvs-usrbin@freefall.cdrom.com,
        rgrimes@freefall.cdrom.com
Sender: cvs-usrbin-owner@freebsd.org
Precedence: bulk

>> This should be `NOSHARED?= BELT_AND_SUSPENDERS_NOSHARED' where
>> ...

>This will not work due to:
>.if defined(NOSHARED)
>LDFLAGS+= -static
>.endif

>NOSHARED?= with any arg value will infact cause it to be defined, even
>a null value.

The first test would have to be more complicated to fix this.

>> BTW, I haven't had any responses to my proposal to change `install' to
>> ${INSTALL} in >= 81 Makefiles.

>I didn't see the proposal.  Yes, please go do this, but it is a very
>small step in the cleanup of Makefiles.  I stopped work on .mk stuff

I need to do it to make a new install flag (-C for compare and don't
change the mtime or the atime if the file hasn't changed) the default
for installing everything the system without making it the default
for `install' itself.  The only point I'm not sure is right is the
use of `${INSTALL}' instead of `${INSTALL} ${INSTALLFLAGS}' in all
Makefiles.  The latter is more verbose and doesn't seem to have
any advantages.  You can always use `install' instead of `${INSTALL}'
for special cases like >= 81 non-special cases already do.  There

>We have tons of Makefile stuff that uses undocumented (via mk/bsd.README
>any way) internal features of the .mk files.  This is seriously bad
>and needs a cleanup.

By documenting it? :-)

>sys.mk has stuff that should not be there, but is due to the design
>of bsd.*.mk.  It should _not_ include bsd.own.mk, that is plain name
>space polution for anyone using make to build things other than BSD
>sources.  It is there to make the current mess work, but needs to
>die.

/etc/make.conf is worse.

>ECHO and ECHODIR are a hack at best and do no belong there in there
>current form.  ECHO should be simply echo, the specialized cases
>for -s and -s -s belong else where.  (Current design does not have
>the else where, my new design does).

ECHO and INSTALL shouldn't be there.  ECHODIR and the fancy `===> dir'
printing shouldn't exist.  Gnu make supports printing the directory
being worked on (-w flag).

Bruce