From owner-freebsd-ports@freebsd.org Tue May 15 01:56:26 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BD9C7EAE965 for ; Tue, 15 May 2018 01:56:25 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: from mail-ot0-f177.google.com (mail-ot0-f177.google.com [74.125.82.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 60BB9711D1 for ; Tue, 15 May 2018 01:56:24 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: by mail-ot0-f177.google.com with SMTP id t1-v6so16621717ott.13 for ; Mon, 14 May 2018 18:56:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OiESzmd+t0mL5YRRAhiMzWpeheCuAcvDk99gcjcALk0=; b=Km0MMlh8qP/C1ZXkj0zeHVhKHn1MN+5r+riX/xhqEkD2c9vAHQ7vPhAGtl3w1eldoZ bVnn3DjWOVbKmetwn4DmyQgzB2wBfCl3bbnTcSBcT7OBClpYgxLbyeLxbCtH8AOGC4xs bfTWAY+kRYQRvlbOHnqP04V0khR19y+x78BSdVUAXRlxx4GYpzIcIc4g6W0fqwhkP4n0 y2auI2RHB8WyIL3tRtfNIyA3vPuEoc2h6KBAiYd86ua+V826mG9xEaBnMZ3Yob45bE1z Hxt0vNk/dMNIj4jJ7HovXGS8yDzRaNi8UjA6O61kPBDJX+xKl4hf5LKSRYXUF7QMInvz jWpw== X-Gm-Message-State: ALKqPweJ8XSawd3N+l6XQOljpQohrrpyou5OL/OIgnrMYoyTcsZiELb/ jpLVzaEyMDr2ZND4tMPF5d28QNpVs6VQg/Nvkp3vLQ== X-Google-Smtp-Source: AB8JxZo+nTkiKyvo3etH0UWkpGmHo755cLkHxn0I8PAhtluhQ7LpaH7OA1t+ntGzRrvuRFW0OSiguz/NRlLn1L+jjXQ= X-Received: by 2002:a9d:48f1:: with SMTP id a46-v6mr8424533otj.94.1526343251635; Mon, 14 May 2018 17:14:11 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Maxim Sobolev Date: Mon, 14 May 2018 17:14:00 -0700 Message-ID: Subject: Re: Practice of "Sponsored by" in commit messages To: "John W. O'Brien" Cc: FreeBSD Ports Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 01:56:26 -0000 What's wrong with a current practice. Why is it of any concern to you, John? Just curious that is not very clear from your message. It is like someone trying to moderate what people in general or some group in particular (e.g. freebsd committers) are allowed to put on their t-shirts just because you find it offensive or inappropriate. -Max On Mon, May 14, 2018, 4:40 PM John W. O'Brien wrote: > Hello FreeBSD Ports, > > The Committer's Guide section on Commit Log Messages [0], doesn't cover > the use of the "Sponsored by" key word. As a non-committer contributor, > it only recently occurred to me to wonder what work that credit is > intended to represent, and whether some light definition would be > helpful to reduce ambiguity. > > When a committer credits a sponsor of theirs, from which the contributor > received no sponsorship, the portrayal feels a little awkward. Does this > strike the list as a problem, and if so, how ought it be solved? > > To make this concrete, allow me to illustrate the situation. > > Alice, working on her own time, prepares and contributes a patch. Bob, > who works for Acme Corp, reviews and commits the patch on company time. > The commit message includes "Sponsored by: Acme Corp". Alice eagerly > awaits her check from Acme Corp. Should the commit message have read > "Sponsored by: Acme Corp (Bob)"? > > This could be extensible to multiple sponsorships. If, instead, Alice > prepares the patch having received a grant to do so from Best Sys Dev, > the commit message could state "Sponsored by: Acme Corp (Bob), Best Sys > Dev (Alice)". > > [0] > > https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/article.html#commit-log-message > > PS: I realize that this issue transcends ports, but it's not clear where > I should send this instead, and this list seems like it would have a > reasonably high concentration of people with a stake in the discussion. > > -- > John W. O'Brien > OpenPGP keys: > 0x33C4D64B895DBF3B > >