From owner-cvs-src@FreeBSD.ORG  Thu Aug 24 16:03:40 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D48A416A4DF;
	Thu, 24 Aug 2006 16:03:40 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 353F043D49;
	Thu, 24 Aug 2006 16:03:39 +0000 (GMT)
	(envelope-from scottl@samsco.org)
Received: from [192.168.254.14] (imini.samsco.home [192.168.254.14])
	(authenticated bits=0)
	by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k7OG3XDK017879;
	Thu, 24 Aug 2006 10:03:38 -0600 (MDT)
	(envelope-from scottl@samsco.org)
Message-ID: <44EDCDD4.6070709@samsco.org>
Date: Thu, 24 Aug 2006 10:03:32 -0600
From: Scott Long <scottl@samsco.org>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
	rv:1.7.7) Gecko/20050416
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Alexander Kabaev <kabaev@gmail.com>
References: <200608240737.k7O7bDMC085424@repoman.freebsd.org>	<20060824092002.44b90594@kan.dnsalias.net>	<20060824133628.GA54467@gvr.gvr.org>
	<20060824101606.414e8bf6@kan.dnsalias.net>
In-Reply-To: <20060824101606.414e8bf6@kan.dnsalias.net>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed 
	version=3.1.1
X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org,
	Guido van Rooij <guido@gvr.org>, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/contrib/ipfilter HISTORY Makefile bpf_filter.c
 ip_fil.c ipf.h ipmon.h ipt.h kmem.h mlfk_rule.c opts.h radix.c
 radix_ipf.h
 snoop.h src/contrib/ipfilter/BSD Makefile Makefile.ipsend kupgrade
 src/contrib/ipfilter/iplang iplang_l.l ...
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Aug 2006 16:03:40 -0000

Alexander Kabaev wrote:

> On Thu, 24 Aug 2006 15:36:28 +0200
> Guido van Rooij <guido@gvr.org> wrote:
> 
> 
>>On Thu, Aug 24, 2006 at 09:20:02AM -0400, Alexander Kabaev wrote:
>>
>>>On Thu, 24 Aug 2006 07:37:12 +0000 (UTC)
>>>Guido van Rooij <guido@FreeBSD.org> wrote:
>>>
>>>
>>>>guido       2006-08-24 07:37:12 UTC
>>>>
>>
>>[..]
>>
>>
>>>>  Log:
>>>>  MFC: ipfilter 4.1.13
>>>
>>>This begs for a question: if ipfilter can not be updated without
>>>breaking the tree anymore, does it belong there in the first place?
>>
>>We could of course also get rid of the tree ;)
>>
>>-Guido
> 
> Tree without ipfilter or ipfilter without tree - this is a
> technicality.
> 
> Seriously though, I wonder how ipfilter is being tested before being
> checked in? Past two commits by you suggested that no testing was done
> at all. 
> 

Missing an added file when doing a check-in is a forgivable mistake, 
especially since Guido isn't the author and likely doesn't have as deep
of an understanding of the changes as the author does.  And, I do highly
appreciate that Guido is responding quickly to the problems.  The 
process with ipfilter still isn't perfect, but it's definitely an
improvement over the past.

Scott