From owner-freebsd-stable@FreeBSD.ORG Thu Apr 8 18:22:35 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CA66F106566C for ; Thu, 8 Apr 2010 18:22:35 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from mail-ww0-f54.google.com (mail-ww0-f54.google.com [74.125.82.54]) by mx1.freebsd.org (Postfix) with ESMTP id 5CD8A8FC19 for ; Thu, 8 Apr 2010 18:22:35 +0000 (UTC) Received: by wwb24 with SMTP id 24so456654wwb.13 for ; Thu, 08 Apr 2010 11:22:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:received:message-id:subject:from:to:cc:content-type; bh=jZoJ3r6ZiVHkfyydQG7ot9nGXB/zYGZXNHIcKlqN8zk=; b=xbdq8WhV/uDCg6Dc3d55qYzEnk9VeknKd160+fAStge/jPqtq0ZRzxw3vYMW4J+s80 ZhlnEDf1m4QWRo3Zt7ApwkIBPMwhCyvpvwi9ULBWFa7l5Ilh8HB6d/908MZCrHfvfsX5 CyZIfse/0ieXASjO84/1S1i/bCbSJ6uWwgkQI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=n/nKcYIYKmf6HQp1lu+sn0vKmClqru0kmIQW3vJYMJzAoOe7Ne3f70kG4OGzcgxnpG PqZ4PY15xbCMQMXkq4WK4YajgPp61hL2PzYzxakZAK4l2m1IJOYBXSv3jtxYJvDbTChI 4/z0VscB3G++p1IWeiPT3/dDkEhwbEk9JAYJY= MIME-Version: 1.0 Received: by 10.216.11.8 with HTTP; Thu, 8 Apr 2010 11:22:34 -0700 (PDT) In-Reply-To: <20100408181741.GI5734@michelle.cdnetworks.com> References: <201004081313.o38DD4JM041821@lava.sentex.ca> <7.1.0.9.0.20100408091756.10652be0@sentex.net> <201004081446.o38EkU7h042296@lava.sentex.ca> <20100408181741.GI5734@michelle.cdnetworks.com> Date: Thu, 8 Apr 2010 11:22:34 -0700 Received: by 10.216.86.203 with SMTP id w53mr246900wee.71.1270750954322; Thu, 08 Apr 2010 11:22:34 -0700 (PDT) Message-ID: From: Jack Vogel To: pyunyh@gmail.com Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-stable@freebsd.org Subject: Re: em driver regression X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Apr 2010 18:22:35 -0000 On Thu, Apr 8, 2010 at 11:17 AM, Pyun YongHyeon wrote: > On Thu, Apr 08, 2010 at 10:46:22AM -0400, Mike Tancsa wrote: > > > > OK, some more data... It seems dhclient is getting upset as well > > since the updated driver > > > > Apr 8 10:28:37 ich10 dhclient[1383]: DHCPDISCOVER on em0 to > > 255.255.255.255 port 67 interval 6 > > Apr 8 10:28:38 ich10 dhclient[1383]: ip length 328 disagrees with > > bytes received 332. > > Apr 8 10:28:38 ich10 dhclient[1383]: accepting packet with data > > after udp payload. > > Apr 8 10:28:38 ich10 dhclient[1383]: DHCPOFFER from 192.168.xx.1 > > Apr 8 10:28:40 ich10 dhclient[1383]: DHCPREQUEST on em0 to > > 255.255.255.255 port 67 > > Apr 8 10:28:40 ich10 dhclient[1383]: ip length 328 disagrees with > > bytes received 332. > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > Try this patch. It should fix the issue. It seems Jack forgot to > strip CRC bytes as old em(4) didn't strip it, probably to > workaround silicon bug of old em(4) controllers. > > Actually it did strip it, but its buried in the code in an obscure way, that's what I just realized by looking at the old code. having the hardware strip will be easier I think. > It seems there are also TX issues here. The system load is too high > and sometimes system is not responsive while TX is in progress. > Because I initiated TCP bulk transfers, TSO should reduce CPU load > a lot but it didn't so I guess it could also be related watchdog > timeouts you've seen. I'll see what can be done. > Will look at that as well. Thanks! Jack