From owner-freebsd-testing@FreeBSD.ORG Tue Jan 21 18:00:20 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id ACA097C5 for ; Tue, 21 Jan 2014 18:00:20 +0000 (UTC) Received: from mail-we0-x233.google.com (mail-we0-x233.google.com [IPv6:2a00:1450:400c:c03::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 48DB91748 for ; Tue, 21 Jan 2014 18:00:20 +0000 (UTC) Received: by mail-we0-f179.google.com with SMTP id w62so8491605wes.10 for ; Tue, 21 Jan 2014 10:00:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=BJsrih2lEZ8yCIboNiALUNWMycp3x9WUiHlsMQElkoE=; b=PY4sz+KDfiD1iIW7ln/xRmm7yhgKG8pHdvJ6CaCqFK7nzwGKKYCkL1vcseQSyye9hN FcLiRBTGvQaafhAzNGzJyncOwg0fgaVKkmkqIOkgO5fv5Ev5+YilcLPD4oXd8X3maAJu lXKDO/08a1OygnwPRVn7cXMuuXvHtSnFJyHZVNuP6L2jxm5NjQcNrPKJzWDE7xr8o0aq u5xRdwqPkuv3ZgKN3DIHqsEHgMJQYHb/knepzY2+hpE97yc3gJXFUT32JTF7HIdtuLjt a77Bj8x4iRBFh4E/3Ia09oOqrd3dgaN4vSz0c2SW0NfRQGtVbigLmvbmiv62hZxslKbg 6LxQ== MIME-Version: 1.0 X-Received: by 10.180.211.39 with SMTP id mz7mr15527516wic.53.1390327218587; Tue, 21 Jan 2014 10:00:18 -0800 (PST) Sender: asomers@gmail.com Received: by 10.194.22.35 with HTTP; Tue, 21 Jan 2014 10:00:18 -0800 (PST) Date: Tue, 21 Jan 2014 11:00:18 -0700 X-Google-Sender-Auth: mUUtiUmejcnnQA7Dis2WBP3gja8 Message-ID: Subject: PATCH: fix "WITH_TESTS=yes make installworld" on amd64 From: Alan Somers To: "freebsd-testing@freebsd.org" Content-Type: text/plain; charset=ISO-8859-1 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jan 2014 18:00:20 -0000 I finally found the problem. Make was trying to install tests during the install32 phase. During this phase, it adds "lib32" to MAKEOBJDIRPREFIX, so it can't find the tests, which were never built with that prefix. The command worked fine when I ran it under "make buildenv", because that uses the normal MAKEOBJDIRPREFIX. I'm not sure what prevented the tests from being built during the lib32 build phase, but this patch will disable tests during both building and installing 32 bit libraries. At work, we never noticed this problem in our SpectraBSD branch because we set WITHOUT_LIB32=1 in /etc/src.conf. Does this patch look ok? Should I be disabling tests some other way? I looked for a way to disable recursing into the tests directories whenever LIBRARIES_ONLY was set, but didn't see an easy way. -Alan Index: Makefile.inc1 =================================================================== --- Makefile.inc1 (revision 260986) +++ Makefile.inc1 (working copy) @@ -417,7 +417,7 @@ -DNO_LINT LIB32WMAKE= ${LIB32WMAKEENV} ${MAKE} ${LIB32WMAKEFLAGS} \ - -DWITHOUT_MAN -DWITHOUT_INFO -DWITHOUT_HTML + -DWITHOUT_MAN -DWITHOUT_INFO -DWITHOUT_HTML -DNO_TESTS LIB32IMAKE= ${LIB32WMAKE:NINSTALL=*:NDESTDIR=*:N_LDSCRIPTROOT=*} -DNO_INCS \ ${IMAKE_INSTALL} .endif