From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Oct 24 14:00:38 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8627516A4D0 for ; Tue, 24 Oct 2006 14:00:38 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3F7B243D7F for ; Tue, 24 Oct 2006 14:00:36 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k9OE0ZXS086881 for ; Tue, 24 Oct 2006 14:00:35 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k9OE0ZM6086880; Tue, 24 Oct 2006 14:00:35 GMT (envelope-from gnats) Resent-Date: Tue, 24 Oct 2006 14:00:35 GMT Resent-Message-Id: <200610241400.k9OE0ZM6086880@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, mark@darklogik.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DD4B816A4F8 for ; Tue, 24 Oct 2006 13:55:25 +0000 (UTC) (envelope-from markzero@corolla.ath.cx) Received: from addr9.addr.com (addr9.addr.com [38.113.244.40]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7A8DE43D81 for ; Tue, 24 Oct 2006 13:55:06 +0000 (GMT) (envelope-from markzero@corolla.ath.cx) Received: from logik.internal.network (localhost [127.0.0.1]) by addr9.addr.com (8.12.11/8.12.8/Submit) with ESMTP id k9ODsrNp007750 for ; Tue, 24 Oct 2006 06:54:56 -0700 (PDT) Received: by logik.internal.network (Postfix, from userid 1001) id BC8EF6449; Tue, 24 Oct 2006 14:54:30 +0100 (BST) Message-Id: <20061024135430.BC8EF6449@logik.internal.network> Date: Tue, 24 Oct 2006 14:54:30 +0100 (BST) From: mark@darklogik.org To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/104752: please update audio/jack to latest version X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mark@darklogik.org List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 14:00:38 -0000 >Number: 104752 >Category: ports >Synopsis: please update audio/jack to latest version >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Oct 24 14:00:35 GMT 2006 >Closed-Date: >Last-Modified: >Originator: mark@darklogik.org >Release: FreeBSD 6.1-SECURITY i386 >Organization: n/a >Environment: System: FreeBSD logik.internal.network 6.1-SECURITY FreeBSD 6.1-SECURITY #0: Mon Aug 28 05:21:08 UTC 2006 root@builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC i386 >Description: This is a request to update audio/jack to the latest version. This may have some remote chance of fixing ports/99323. I realise this will probably have to happen later, due to the ports freeze. >How-To-Repeat: >Fix: The latest version does not compile cleanly. There is one instance of code using 'ENODATA', which FreeBSD doesn't have. I have notified the original developers but have had no reply yet (I sent an email about ten minutes ago). The following dirty hack will allow it to compile (ENODATA is only used by clients wishing to check errors from the new MIDI code, it should be fine as long as clients are compiled against this version of the jack library, hopefully the original developers will come up with something cleaner): --- libjack/midiport.c.orig Tue Oct 24 14:38:20 2006 +++ libjack/midiport.c Tue Oct 24 14:38:41 2006 @@ -26,6 +26,11 @@ #include #include +/* FreeBSD (at least) does not have ENODATA */ +#ifndef ENODATA +#define ENODATA (ELAST + 1) +#endif + typedef struct _jack_midi_port_info_private { jack_midi_port_info_t info; jack_nframes_t last_write_loc; /**< Used for both writing and mixdown */ There is also one error which I've left it up to the maintainer to fix because I'm not sure about the proper solution to it. This code appears in config/os/generic/time.h: inline jack_time_t jack_get_microseconds (void) { return jack_get_microseconds_from_system (); } Later on this function is (accidentally?) redefined in libjack/time.c as: jack_time_t jack_get_microseconds_from_system (void) { ... This causes a compile error along the lines of: In file included from ../config/sysdeps/time.h:9, from ../jack/internal.h:56, from time.c:35: ../config/os/generic/time.h: In function `jack_get_microseconds': ../config/os/generic/time.h:29: warning: implicit declaration of function `jack_get_microseconds_from_system' time.c: At top level: time.c:80: error: conflicting types for 'jack_get_microseconds_from_system' ../config/os/generic/time.h:29: error: previous implicit declaration of 'jack_get_microseconds_from_system' was here *** Error code 1 >Release-Note: >Audit-Trail: >Unformatted: