From owner-svn-src-projects@FreeBSD.ORG Thu Jul 5 21:11:03 2012 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DD8D71065672; Thu, 5 Jul 2012 21:11:03 +0000 (UTC) (envelope-from cherry@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id C94C48FC14; Thu, 5 Jul 2012 21:11:03 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q65LB3pj018696; Thu, 5 Jul 2012 21:11:03 GMT (envelope-from cherry@svn.freebsd.org) Received: (from cherry@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q65LB3Gl018694; Thu, 5 Jul 2012 21:11:03 GMT (envelope-from cherry@svn.freebsd.org) Message-Id: <201207052111.q65LB3Gl018694@svn.freebsd.org> From: "Cherry G. Mathew" Date: Thu, 5 Jul 2012 21:11:03 +0000 (UTC) To: src-committers@freebsd.org, svn-src-projects@freebsd.org X-SVN-Group: projects MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r238150 - projects/amd64_xen_pv/sys/amd64/amd64 X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2012 21:11:04 -0000 Author: cherry Date: Thu Jul 5 21:11:03 2012 New Revision: 238150 URL: http://svn.freebsd.org/changeset/base/238150 Log: Cosmetic change: use macro TRAPF_USERMODE() where possible. Approved by: gibbs (implicit) Modified: projects/amd64_xen_pv/sys/amd64/amd64/trap.c Modified: projects/amd64_xen_pv/sys/amd64/amd64/trap.c ============================================================================== --- projects/amd64_xen_pv/sys/amd64/amd64/trap.c Thu Jul 5 20:51:44 2012 (r238149) +++ projects/amd64_xen_pv/sys/amd64/amd64/trap.c Thu Jul 5 21:11:03 2012 (r238150) @@ -280,7 +280,7 @@ trap(struct trapframe *frame) * interrupts disabled until they are accidentally * enabled later. */ - if (ISPL(frame->tf_cs) == SEL_UPL) + if (TRAPF_USERMODE(frame)) uprintf( "pid %ld (%s): trap %d with interrupts disabled\n", (long)curproc->p_pid, curthread->td_name, type); @@ -304,7 +304,7 @@ trap(struct trapframe *frame) code = frame->tf_err; - if (ISPL(frame->tf_cs) == SEL_UPL) { + if (TRAPF_USERMODE(frame)) { /* user trap */ td->td_pticks = 0; @@ -793,7 +793,7 @@ trap_fatal(frame, eva) else msg = "UNKNOWN"; printf("\n\nFatal trap %d: %s while in %s mode\n", type, msg, - ISPL(frame->tf_cs) == SEL_UPL ? "user" : "kernel"); + TRAPF_USERMODE(frame) ? "user" : "kernel"); #ifdef SMP /* two separate prints in case of a trap on an unmapped page */ printf("cpuid = %d; ", PCPU_GET(cpuid)); @@ -809,7 +809,7 @@ trap_fatal(frame, eva) } printf("instruction pointer = 0x%lx:0x%lx\n", frame->tf_cs & 0xffff, frame->tf_rip); - if (ISPL(frame->tf_cs) == SEL_UPL) { + if (TRAPF_USERMODE(frame)) { ss = frame->tf_ss & 0xffff; esp = frame->tf_rsp; } else { @@ -945,7 +945,7 @@ amd64_syscall(struct thread *td, int tra ksiginfo_t ksi; #ifdef DIAGNOSTIC - if (ISPL(td->td_frame->tf_cs) != SEL_UPL) { + if (!TRAPF_USERMODE(td->td_frame)) { panic("syscall"); /* NOT REACHED */ }