Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 30 Dec 2023 00:00:57 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 276002] nfscl: data corruption using copy_file_range
Message-ID:  <bug-276002-227-AF9h3bpXvz@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-276002-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-276002-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002

--- Comment #2 from Rick Macklem <rmacklem@FreeBSD.org> ---
Do we also need to add something like...

   if ((obj =3D invp->v_object) !=3D NULL &&
       vm_object_mightbedirty(obj)) {
          VM_OBJECT_WLOCK(obj);
          vm_object_page_clean(obj, 0, 0, OBJPC_SYNC);
          VM_OBJECT_WUNLOCK(obj);
    }
in front of the
    error =3D ncl_flush(invp, MNT_WAIT, curthread, 1, 0);

If this is needed, the vnode locking code will need to be
changed to LK_EXCLUSIVE lock the invp.

Man, I hate mmap'd I/O.;-)

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-276002-227-AF9h3bpXvz>