From owner-svn-ports-all@FreeBSD.ORG Mon Dec 2 03:47:14 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9E3DA252 for ; Mon, 2 Dec 2013 03:47:14 +0000 (UTC) Received: from nm47-vm1.bullet.mail.bf1.yahoo.com (nm47-vm1.bullet.mail.bf1.yahoo.com [216.109.115.124]) by mx1.freebsd.org (Postfix) with SMTP id 2603E6DCA for ; Mon, 2 Dec 2013 03:47:13 +0000 (UTC) Received: from [98.139.215.143] by nm47.bullet.mail.bf1.yahoo.com with NNFMP; 02 Dec 2013 03:40:24 -0000 Received: from [98.139.211.195] by tm14.bullet.mail.bf1.yahoo.com with NNFMP; 02 Dec 2013 03:40:24 -0000 Received: from [127.0.0.1] by smtp204.mail.bf1.yahoo.com with NNFMP; 02 Dec 2013 03:40:24 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1385955624; bh=8yUpldcpLkGP30/45929i6oH8cnYBI+EWHW/wbWSwg8=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Subject:From:Reply-To:To:Cc:In-Reply-To:References:Content-Type:Date:Message-ID:Mime-Version:X-Mailer; b=cq/1i2IEIsblr3/UzLasMoqiLbG4OyR17lFD2CG/ACJ7bFt19OWxT6CGYPwAsIINBWodKvQBPrrNSyrliPYJs81a5HjmdPqhPbh+ZzOhEM4gQssl20QOfMsWKlCSdF1qcS841GBYV9gNBRPRM3NlEgUyP4ckt5p4o9jbqwfIf4I= X-Yahoo-Newman-Id: 256022.1033.bm@smtp204.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 2Z9BPA4VM1n84q5gxrLk5fPRThE2OZHwCDGToRWdcP0neTk dPUECV4pw6GigrzLeOZYM_.bc0GpeJtMBwkBWlxXwvJ78LnKITtLIbEyXDp9 MJMkwtM5Ett14AFFPLfeHa5d1x67RQ4QJ4aLvVXKwN1h6uSvy5OBGs8N.tN7 VG8tkGWvovwOeLkD57g8ErShu0sojmiBI2iIJwS1.yEpPa2D3GcnkcoEJISA zNoOrl87EQm7jKOU1z1QM6oZqAkOmNEdQsoGYcFmSMEgctskok3nk3tbWksg lRtd6_WffKDruG1DE4nlAWhSAfnElJ0qiv5gRpx3bo.HXC_._xLfc5Z2LGWA nmBI6iNNtRltm9lvGAoJqcUJpiko_ml9nXUZNy1fVu932X2uNHeqYkZbpeXq w9vdjVff0roXXzD57ZffTSVjkYzePdzHxFPd1eQ3Z0sQAbdGg0kIROf2LPr0 jjBrNZF9pq2pE1wM1S11e0Y.t_xwO.RQLlPE.LkW55PwF2AKtPns6jZyBOPM 14I81LPG.zIeLqK6neLj9c324qeDkbSkBY4y7Fp4S7SuPyJuWNCmbQY14vav jSEcDXh725_2O6kcJPFD0sYjtmDvHtgUmSc1.7vpTnFTIwho_V5gv.Bid2if eW96rgg8svN4mLV5vG217vNcsSxk- X-Yahoo-SMTP: u5BKR6OswBC_iZJVfGRoMkTIpc8pEA4- X-Rocket-Received: from [192.168.100.228] (sean_bruno@24.23.220.111 with ) by smtp204.mail.bf1.yahoo.com with SMTP; 01 Dec 2013 19:40:24 -0800 PST Subject: Re: svn commit: r335260 - in head/audio/clementine-player: . files From: Sean Bruno To: Max Brazhnikov In-Reply-To: <1587696.zcDM98VLUm@mercury.ph.man.ac.uk> References: <201311300354.rAU3sGQD056367@svn.freebsd.org> <1587696.zcDM98VLUm@mercury.ph.man.ac.uk> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-pRQw7Qmo40fkzAHtbSi4" Date: Sun, 01 Dec 2013 19:40:22 -0800 Message-ID: <1385955622.1498.114.camel@powernoodle.corp.yahoo.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, vg@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list Reply-To: sbruno@freebsd.org List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Dec 2013 03:47:14 -0000 --=-pRQw7Qmo40fkzAHtbSi4 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On Sun, 2013-12-01 at 17:41 +0000, Max Brazhnikov wrote:=20 > Hi Sean, >=20 > On Sat, 30 Nov 2013 03:54:16 +0000Sat Nov 30 03:54:16 2013 Sean Bruno wro= te: > > Author: sbruno (src committer) > > Date: Sat Nov 30 03:54:16 2013 > > New Revision: 335260 > > URL: http://svnweb.freebsd.org/changeset/ports/335260 > >=20 > > Log: > > Update audio/clementine-player to 1.2.0 > > =20 > > This now works on 11-current > > =20 > > PR: ports/178687 >=20 > Was this update approved? >=20 I'm going to go with "no" as vg@ did not review completely nor did he explicitly give approval. The port was completely broken, so I fixed it. =20 > > +WITH_DEBUG=3D yes >=20 > WITH_DEBUG shouldn't be set in Makefiles >=20 Ah, debugging leftover. Will remove. > > INSTALLS_ICONS=3D yes > > USE_GSTREAMER=3D gio ogg mp3 flac soup vorbis > > MAKE_JOBS_UNSAFE=3D yes > > CONFLICTS_BUILD=3D qt-3.* > > =20 > > CMAKE_ARGS+=3D -DCMAKE_LIBRARY_PATH:PATH=3D"${LOCALBASE}/lib:${PREFIX}= /lib" \ > > - -DENABLE_IMOBILEDEVICE=3DOFF > > + -DENABLE_IMOBILEDEVICE=3DOFF -DENABLE_SPARKLE=3DOFF \ > > + -DENABLE_SOUNDMENU=3DOFF -DENABLE_DBUS=3DOFF -DENABLE_UBUNTU_ONE=3DO= FF \ > > + -DENABLE_DROPBOX=3DOFF -DENABLE_SKYDRIVE=3DOFF >=20 > You have globally disabled DBus support here, which looks wrong, consider= ing > that you have added DBUS options. There's more issues with dbus in this p= ort, > see below. > =20 More debugging leftover. I'll remove this. > > + > > +.if ${PORT_OPTIONS:MUSE_BUILTIN_TAGLIB} > > +CMAKE_ARGS+=3D -DENABLE_USE_BUILTIN_TAGLIB=3DON > > +.else > > +CMAKE_ARGS+=3D -DENABLE_USE_BUILTIN_TAGLIB=3DOFF > > +.endif >=20 > What's the reason for this option? We usually try to avoid build-in > dependencies. >=20 The builtin taglib is much smaller, and less feature rich compared to using the external audio/taglib. So, its a feature of the application and it seems to work. I've set it to off by default, and I don't see the harm in letting users configure it. > > .if ${PORT_OPTIONS:MWIIMOTEDEV} > > -CMAKE_ARGS+=3D -DENABLE_WIIMOTEDEV=3DON > > +CMAKE_ARGS+=3D -DENABLE_WIIMOTEDEV=3DON \ > > + -DENABLE_DBUS=3DON >=20 > You'll end up with both -DENABLE_DBUS=3DON and -DENABLE_DBUS=3DOFF, if yo= u try > to build the port with WIIMOTEDEV, but without DBUS option. You either ha= ve > to fiddle with options to avoid this, or remove DBUS option for simplicit= y. > As far as I remember WIIMOTEDEV is not the only option that requires dbus > support, please check it if you want to keep DBUS option. >=20 Agreed. This is a misconfiguration. Cmake was hiding this from me by doing the right thing. > > Modified: head/audio/clementine-player/pkg-plist > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/audio/clementine-player/pkg-plist Sat Nov 30 02:27:05 2013 (r3= 35259) > > +++ head/audio/clementine-player/pkg-plist Sat Nov 30 03:54:16 2013 (r3= 35260) >=20 > >=20 > > +share/clementine/projectm-presets/Rovastar - Inner Thoughts (Clouded J= udgement Mix).milk > > +share/clementine/projectm-presets/Che - Burning Hus.milk > > +@dirrmtry share/applications >=20 > share/applications is a part of mtree now, it shouldn't be in plist. >=20 > Regards, > Max >=20 >=20 Fixed. Thanks. I suspect that I should actually go through the process of getting a port commit "bit" for stuff. Especially if I'm going to be playing around in here. :-) sean --=-pRQw7Qmo40fkzAHtbSi4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iQEcBAABAgAGBQJSnAEiAAoJEBkJRdwI6BaHeJcH/RzM4RkRCqFRmhH9oH1ks3EL p5R9b1z3s23axjAMLtxwlmKBd8/N1nq/Rl1KgV5ybvqhUOM2eE78KB4BSeA76Cn3 XQ91gKWlaWQxlWqdkSbECuAd4MQYLsgfKJc5j9nFrvu4umFwzzK9mEslnLqJ8if2 V5pYZ29uaUuCJDKy0ujwWiQIF3j7Ef7EmfhtMAAWu1oMT+1X284nq3cx3W0AjuRq wezbwWhJjzI6YeZ21xH9xuCdsnMEB42OXc/yoANc9g07BYgsrAg81o5fhnNiu+Sj /mvK6rITw3KQryZjRLbq5vdiWTWzwtBV9j9vR/5h01stPcOk4SCRBNGC7/+nEw4= =t7sr -----END PGP SIGNATURE----- --=-pRQw7Qmo40fkzAHtbSi4--