Date: Wed, 2 Nov 2011 14:42:26 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Alexander Motin <mav@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r227015 - head/sys/geom Message-ID: <20111102134226.GA1656@garage.freebsd.pl> In-Reply-To: <201111020924.pA29OxUV009135@svn.freebsd.org> References: <201111020924.pA29OxUV009135@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 02, 2011 at 09:24:59AM +0000, Alexander Motin wrote: > Author: mav > Date: Wed Nov 2 09:24:59 2011 > New Revision: 227015 > URL: http://svn.freebsd.org/changeset/base/227015 >=20 > Log: > Add mutex and two flags to make orphan() call properly asynchronous: > - delay consumer closing and detaching on orphan() until all I/Os comp= lete; > - prevent new I/Os submission after orphan() called. > Previous implementation could destroy consumers still having active > requests and worked only because of global workaround made on GEOM leve= l. Alexander, I'm not sure I agree with your recent changes to address this. The checks in GEOM were there to avoid the need for counting outstanding I/O requests in every single GEOM class. Why do you think the checks in GEOM are not good enough? Can we design solution that can be implemented in the framework itself, so simple GEOM classes can stay simple? --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --1yeeQ81UyVL57Vl7 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk6xSMIACgkQForvXbEpPzR76ACfcnD2VIq+gZP/9wz8VrlaZrwE McUAnj2DgGFLNV5j6g068uyWkM0C3qs8 =eTX9 -----END PGP SIGNATURE----- --1yeeQ81UyVL57Vl7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111102134226.GA1656>